-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Add scripts for Fedora systems #28791
base: master
Are you sure you want to change the base?
Conversation
542b367
to
91501a5
Compare
Always nice to see more of these! Do you mind amending your commit title to prefix it with "Tools: " |
No problem, I will add it |
In CLI: change your commit title Then,
For reference: https://ardupilot.org/dev/docs/submitting-patches-back-to-master.html#preparing-commits |
91501a5
to
bc0c668
Compare
sorry, I accidentally deleted my branch while cleaning up my repo |
No worries. Looks like you also added a merge commit. ArduPilot uses a rebase workflow. I'll drop that off your branch and force push. Looks fine otherwise! |
3a435b9
to
52ec360
Compare
Alrighty, all cleaned up. Approved! I requested final review from a maintainer. If you have time, mind trying to add a job in CI to enforce this script can continue to work as you intended as a follow up PR? |
Eh, maybe not, I don't think we can run these setup scripts tests on fedora in CI: Maybe you know a way? |
I'd like to help, but I don't think I have time to do the CI part. I'm still new to github, still have to learn more about the testing and CI part since I never used it before anyway, thank you for reviewing the PR |
This script is basically the modification from OpenSUSE Tumbleweed environment install script. The only changes was about the python package names with awk and some renaming to match fedora packages. Tested and the resulting environment is able to compile ArduCopter for Pixhawk1 (STM32) and ESP32S3 Devkit without error. The resulting binaries have not been tested yet