Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Add scripts for Fedora systems #28791

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

radityankn
Copy link
Contributor

This script is basically the modification from OpenSUSE Tumbleweed environment install script. The only changes was about the python package names with awk and some renaming to match fedora packages. Tested and the resulting environment is able to compile ArduCopter for Pixhawk1 (STM32) and ESP32S3 Devkit without error. The resulting binaries have not been tested yet

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 2, 2024

Always nice to see more of these! Do you mind amending your commit title to prefix it with "Tools: "

@radityankn
Copy link
Contributor Author

Always nice to see more of these! Do you mind amending your commit title to prefix it with "Tools: "

No problem, I will add it

@radityankn radityankn changed the title Add scripts for Fedora systems Tools: Add scripts for Fedora systems Dec 2, 2024
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 2, 2024

By commit, I mean here:
image

In CLI:
git commit --amend

change your commit title

Then,

git push -f

For reference: https://ardupilot.org/dev/docs/submitting-patches-back-to-master.html#preparing-commits

@radityankn radityankn closed this Dec 3, 2024
@radityankn radityankn deleted the fedora_script branch December 3, 2024 01:06
@radityankn radityankn restored the fedora_script branch December 3, 2024 01:06
@radityankn radityankn reopened this Dec 3, 2024
@radityankn
Copy link
Contributor Author

radityankn commented Dec 3, 2024

sorry, I accidentally deleted my branch while cleaning up my repo

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 3, 2024

No worries. Looks like you also added a merge commit. ArduPilot uses a rebase workflow. I'll drop that off your branch and force push. Looks fine otherwise!

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 3, 2024

Alrighty, all cleaned up. Approved! I requested final review from a maintainer.

If you have time, mind trying to add a job in CI to enforce this script can continue to work as you intended as a follow up PR?
We have run through many of the setup scripts in this workflow.
It can be amended to support fedora.
https://github.com/ArduPilot/ardupilot/blob/master/.github/workflows/test_environment.yml

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 3, 2024

Eh, maybe not, I don't think we can run these setup scripts tests on fedora in CI:
actions/runner-images#10802

Maybe you know a way?

@radityankn
Copy link
Contributor Author

radityankn commented Dec 3, 2024

I'd like to help, but I don't think I have time to do the CI part. I'm still new to github, still have to learn more about the testing and CI part since I never used it before

anyway, thank you for reviewing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants