AP_HAL_ESP32: check UART thread ownership #29003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks that UART driver functions are called on the thread the port is initialised on, and handle a change of thread ownership.
Motivation
UARTDriver::_begin
with a baudrate of zero (for example when changing the thread owning the UART while initialising the AP_MSP_Telem_Backend) causes a core panic due to an integer division by zero exception.Testing
esp32s3empty
.SERIAL3_BAUD 115
.SERIAL3_PROTOCOL 32
.