ardupilot_ros: Restructured repository to accomodate more custom ROS packages and features #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have updated the colcon CI with the updated package names. So after merge it should solve the issue |
Ryanf55
requested changes
Jan 18, 2025
snktshrma
force-pushed
the
ros/humble
branch
6 times, most recently
from
d495465 to
da04985
Compare
Ryanf55
reviewed
Jan 20, 2025
| ```bash | ||
| cd ~/ros2_ws | ||
| source install/setup.bash | ||
| ros2 launch ardupilot_cartographer cartographer.launch.py |
There was a problem hiding this comment.
Can we avoid directly duplicating the README contents?
Perhaps try to keep the cartographer specific stuff here, and then just refer to the cartographer directory from top level.
There was a problem hiding this comment.
I kept system requirements and overall build part in top level directory and instead of details on cartographer, I referred to it from that. In cartographer directory, I kept usage part only, referring to setup in parent's readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructuring the overall repository to allow addition of new ros packages and features