New module for uploading to the SFTP the results of a batch #433
Conversation
| sftp = self.relecov_sftp.sftp | ||
|
|
||
| # Define the remote path where the file is to be uploaded | ||
| remote_dir = f"/{cod}/ANALYSIS_RESULTS" |
There was a problem hiding this comment.
Maybe this folder name ANALYSIS_RESULTS should be in the conf file?
There was a problem hiding this comment.
@saramonzon Do you think this should be added as a new field in configuration.json or as a new entry from sftp_handle, for example, as "analysis_results_folder": "ANALYSIS_RESULTS"?
relecov-tools/relecov_tools/conf/configuration.json
Lines 242 to 278 in 38b7602
There was a problem hiding this comment.
I think it should be fine in sftp_handle :)
|
|
||
| if not matching_cod: | ||
| stderr.print(f"[red]Batch {self.batch_id} was not found in any COD* folder.") | ||
| sys.exit(1) |
There was a problem hiding this comment.
use raise and handle upstream
There was a problem hiding this comment.
If I am not wrong this could be changed by:
if not matching_cod:
raise FileNotFoundError(f"Batch {self.batch_id} was not found in any COD* folder.")
What do you mean by "handle upstream" though? @saramonzon
There was a problem hiding this comment.
at some point (in the main.py) this raise must be handle so the user does not get an error but a error message, you can use the debug flag that @albatalavera introduced, so if debug you show the traceback from the raise, and if not you only show the message with the sys.exit("message") but in the main, no in a "inside code function"
|
|
||
| if not template_path: | ||
| stderr.print("[red]Error: You must provide a template_path as an argument.") | ||
| sys.exit(1) |
There was a problem hiding this comment.
@Shettland in the class init methods should we use also raise? Or here is like in main that it's fine to use it?
We may have a lot of sys.exit in init methods, not sure if in relecov-tools but on bu-isciii tools for sure
There was a problem hiding this comment.
here let's discuss this with @Shettland in case we need to do the same here, in the case of the other function is clear, i'm not sure in this case
|
Also pyzipper must be add to requirements.txt |
This PR introduces the
upload_resultsmodule, which automates the process of uploading batch results to their respective COD folders. The module performs the following tasks: