-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add storage expansion results to Grid #104
Conversation
Correct me if I'm wrong: there are two parameters that we need to extract for each storage expansion candidate: 1) capacity, which is specified within the group of generators, i.e. |
This is correct.
This is a very good question! I don't know, but we have the same concerns for generation and transmission. Currently, we are processing the Switch results as if they are cumulative, but that could be wrong. It will need further investigation. |
3145892
to
3b2c369
Compare
721ac97
to
fe6c3a0
Compare
I added a couple more commits so that we can successfully call
|
9497144
to
a5e5b29
Compare
Looks good to me. We can merge this once @YifanLi86 is happy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like it!
f6e78a4
to
fb5a8ac
Compare
Pull Request doc
Purpose
What the code is doing
recover_storage_buses
function which translates Switch storage expansion candidates into bus IDs (following the pattern from feat: add storage candidate buses to Switch input preparation #101)split_plant_existing_expansion
function which separates a list of plant IDs into real and hypothetical (this was needed to fix a bug that popped up withinadd_gen_upgrades_to_grid
, when existing generators withPmax = 0
are present in the input data).extract_build_decisions
is expanded to return generation, transmission, and storage energy decisions.add_gen_upgrades_to_grid
, we make some small changes to indexing to ensure that we only process generator expansions (not storage, not existing generators).add_storage_upgrades_to_grid
, which does what's expected following the name.Testing
Tested manually on results files generated both with and without storage candidates.
Code used to prepare inputs with storage candidates:
To analyze the results:
For this example, there are storage results, as verified via:
But no storage capacity is build, so there is no storage added to the resulting Grid:
Time estimate
30 minutes.