Skip to content

Fix crash that results from duplicating a georeference #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented May 23, 2025

Description

This PR resolves a crash that happened while duplicating a CesiumGeoreference in the Unreal Editor.

Issue number or link

Fixes #1354.

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
    - [ ] I have added or updated unit tests to ensure consistent code coverage as necessary.
    - [ ] I have updated the documentation as necessary.

Testing plan

Simple to test, just duplicate or copy + paste a CesiumGeoreference and verify it won't crash. Also sanity check other operations like undo / redo, deleting, etc.

@kring
Copy link
Member

kring commented May 27, 2025

Thanks @j9liu!

@kring kring merged commit 0ad7a8e into main May 27, 2025
43 of 44 checks passed
@kring kring deleted the null-georeference-checks branch May 27, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicating CesiumGeoreference causes crash
2 participants