-
Notifications
You must be signed in to change notification settings - Fork 91
Re-implement More Vanilla Turret patches #1165
base: master
Are you sure you want to change the base?
Re-implement More Vanilla Turret patches #1165
Conversation
@N7Huntsman - I'm going to need some help with the issue where Plasma mortars are not craftable at the Machining Table/Bench , since they otherwise work correctly. |
<recoilPattern>Mounted</recoilPattern> | ||
</Properties> | ||
<AmmoUser> | ||
<magazineSize>100</magazineSize> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100 seems a bit low when this thing can blow through that in 3 bursts. Doesn't quite sell the 'unrelenting lead storm' if it needs reloaded every other volley.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<recoilAmount>0.83</recoilAmount> | ||
<verbClass>CombatExtended.Verb_ShootCE</verbClass> | ||
<hasStandardCommand>true</hasStandardCommand> | ||
<defaultProjectile>Bullet_50BMG_FMJ</defaultProjectile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given it's size, .50 cal is probably too much. The turret description calls it an upgrade to the vanilla turret (which uses 5.56mm NATO), so perhaps 7.62mm NATO would be appropriate?
<hasStandardCommand>true</hasStandardCommand> | ||
<defaultProjectile>Bullet_83mmSMAW_HEAT</defaultProjectile> | ||
<warmupTime>2.09</warmupTime> | ||
<range>48</range> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty short, given what they're firing.
<reloadTime>15.6</reloadTime> | ||
<ammoSet>AmmoSet_50BMG</ammoSet> | ||
</AmmoUser> | ||
<FireModes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking for auto turrets, they don't have a burst fire mode, and simply use automatic with the auto burst being the desired number of rounds (mainly, I suspect, because there's not a flick switch job associated with changing the fire modes). This should be changed for the automated versions of the military turret and precision turret (which I'd make single fire anyway). Can be left for the manned versions, since there's a operator.
<!-- ========== Gun Complex ========== --> | ||
|
||
<li Class="CombatExtended.PatchOperationMakeGunCECompatible"> | ||
<defName>Gun_GunComplex</defName> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting an error: Config error in GunComplex: has duplicate thingCategory BuildingsSecurity.
Probably just an inheritance issue to resolve.
</value> | ||
</li> | ||
|
||
<!-- ========== Shredder Turret ========== --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yellow message in logs. Shredder turret gun (12 Gauge) burst fire shot count is same or higher than auto fire.
Somewhat odd, given the turret can't be set to burst fire anyway.
So the Issues @N7Huntsman Mentioned above with the Red Errors popping up are related to OUR code, there is currently an issue where human pawns are trying to fire empty turrets.. Once the code is fixed we will be able to / and have to, Retest this patch to make sure there are no residual errors lying around within the patch itself.. At this time we can not test the patch ... I will post another comment when we can resume testing and our internal error has been resolved. |
@zhrocks11 - Thanks for letting me know.
|
Additions
Changes
weaponTag
PatchOp that failed, and prevented subsequent patches from working properlyReferences
TODO: