Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] Set fixed top menu bar height #2209

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[Style] Set fixed top menu bar height #2209

merged 2 commits into from
Jan 9, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jan 9, 2025

Ref:

Having top menu bar height vary with content is generally a bad design, as the extra height really screws up the overall styles. Considering we are also hosting extension-added widgets on the top menu bar. Using REM here to account different browser font size.

@huchenlei huchenlei requested a review from a team as a code owner January 9, 2025 18:57
@huchenlei huchenlei merged commit 906b5e3 into main Jan 9, 2025
10 checks passed
@huchenlei huchenlei deleted the fixed_menu_height branch January 9, 2025 19:14
@JorgeR81
Copy link

JorgeR81 commented Jan 10, 2025

I have a 1920 x 1080 display.
For me the Top bar it's 39 pixels height.

If the Top bar now has a fixed height, why not make it 40 pixels, instead ?

This way:

  • The Top bar would have the same exact thickness as the small Sidebar.
  • The Queue button would have a margin of 2 pixels above and below. 
    This is how it looks now: ( 1 pixel above, 2 below )

q0

@jeery-star
Copy link

The design is not reasonable, can not adapt to the screen, really do not know what the designer has in mind, anti-human design

@webfiltered
Copy link
Contributor

@jeery-star Please open an issue if you are having an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants