-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUOS-2738][risk=no] Refactor dataset submission form validation #2358
Conversation
* @param errors Schema validation errors from Ajv | ||
* @returns {{}} | ||
*/ | ||
function errorsToValidation(errors) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code, and below, is essentially lifted from the deleted JsonSchemaUtils.js
. This way, there are no changes to how dependent UI components handle validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor lgtm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! 👍
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2738
Summary
Note that this does not add the same kind of consent group name unique checks to the Study Update page. Will tackle that in a separate story.
Have you read Terra's Contributing Guide lately? If not, do that first.