Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2789] Switch pages and components to JSX #2397

Merged
merged 25 commits into from
Nov 27, 2023
Merged

Conversation

fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2789

Summary

Switch pages and components to JSX


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois force-pushed the fb-duos-2789-jsx-only branch 13 times, most recently from c059e4c to 58b800d Compare November 14, 2023 19:18
@fboulnois fboulnois marked this pull request as ready for review November 14, 2023 19:18
@fboulnois fboulnois requested a review from a team as a code owner November 14, 2023 19:18
@fboulnois fboulnois force-pushed the fb-duos-2789-jsx-only branch from 58b800d to a230f7c Compare November 14, 2023 19:29
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the lint warnings, changes look good!

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍🏽

Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@rushtong rushtong merged commit 965ce31 into develop Nov 27, 2023
9 checks passed
@rushtong rushtong deleted the fb-duos-2789-jsx-only branch November 27, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants