Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1082: Bug fix for correct manage DAC link location #2742

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Dec 4, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DT-1082

Summary

Minor fix to determine the correct manage DAC url path


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review December 4, 2024 14:55
@rushtong rushtong requested a review from a team as a code owner December 4, 2024 14:55
@rushtong rushtong requested review from s-rubenstein and cinyecai and removed request for a team December 4, 2024 14:55
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rushtong rushtong merged commit 748caa6 into develop Dec 6, 2024
9 checks passed
@rushtong rushtong deleted the gr-DT-1082-fix-edit-dac-link branch December 6, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants