Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate transaction status queue for transparent history #1559

Merged
merged 17 commits into from
Aug 20, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Aug 10, 2024

Note
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review your own code in GitHub's web interface1
  • Add automated tests as appropriate
  • Update the manual tests2 as appropriate
  • Check the code coverage3 report for the automated tests
  • Update documentation as appropriate (e.g README.md, Architecture.md, etc.)
  • Run the demo app and try the changes
  • Pull in the latest changes from the main branch and squash your commits before assigning a reviewer4

Reviewer

  • Check the code with the Code Review Guidelines checklist
  • Perform an ad hoc review5
  • Review the automated tests
  • Review the manual tests
  • Review the documentation, README.md, Architecture.md, etc. as appropriate
  • Run the demo app and try the changes6

Footnotes

  1. Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.

  2. While we aim for automated testing of the SDK, some aspects require manual testing. If you had to manually test
    something during development of this pull request, write those steps down.

  3. While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check for Kotlin modules and ./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true for Android modules.

  4. Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

  5. In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.

  6. While the CI server runs the demo app to look for build failures or crashes, humans running the demo app are
    more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

Copy link
Contributor

@HonzaR HonzaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a few minor comments and left one important suggestion inline.

Base automatically changed from tor-exchange-rate to feature-2.2.0 August 13, 2024 18:46
@str4d str4d force-pushed the transparent-history branch from c8563fd to 6c12d04 Compare August 13, 2024 18:48
@str4d
Copy link
Contributor Author

str4d commented Aug 13, 2024

Rebased on feature-2.2.0 to bring in latest main and squash the fixes for librustzcash updates into the first commit.

@str4d str4d force-pushed the transparent-history branch from 6c12d04 to ab01835 Compare August 13, 2024 22:16
@str4d
Copy link
Contributor Author

str4d commented Aug 13, 2024

Force-pushed to update the librustzcash revision, and fix RawTransactionUnsafe to handle the height parameter correctly.

str4d and others added 2 commits August 14, 2024 07:55
- Distinct between decryptAndStoreTransaction and setTransactionStatus path by minedHeight
- Convert from RawStatusUnsafe to TransactionStatus
- Add RawTransaction object and related functions
- These changes resolve older issue #1254
- New backend.transactionDataRequests and related logic is now used within CompactBlockProcessor
- getTAddressTransactions from LightWalletclient module is now newly used
- These also changes remove now unused querying transactions-related functions from  v_transactions
Copy link
Contributor

@HonzaR HonzaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used both new FFI endpoints. I have two questions inline, though. @str4d, please.

@HonzaR HonzaR requested a review from Milan-Cerovsky August 16, 2024 12:34
@nuttycom nuttycom force-pushed the transparent-history branch from 558b509 to d14a6b0 Compare August 19, 2024 13:17
@HonzaR HonzaR marked this pull request as ready for review August 19, 2024 20:40
@HonzaR HonzaR merged commit a870003 into feature-2.2.0 Aug 20, 2024
11 of 12 checks passed
@HonzaR HonzaR deleted the transparent-history branch August 20, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants