-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate transaction status queue for transparent history #1559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a few minor comments and left one important suggestion inline.
sdk-lib/src/main/java/cash/z/ecc/android/sdk/block/processor/CompactBlockProcessor.kt
Outdated
Show resolved
Hide resolved
c8563fd
to
6c12d04
Compare
Rebased on |
6c12d04
to
ab01835
Compare
Force-pushed to update the |
sdk-lib/src/main/java/cash/z/ecc/android/sdk/block/processor/CompactBlockProcessor.kt
Outdated
Show resolved
Hide resolved
- Distinct between decryptAndStoreTransaction and setTransactionStatus path by minedHeight - Convert from RawStatusUnsafe to TransactionStatus - Add RawTransaction object and related functions - These changes resolve older issue #1254
sdk-lib/src/main/java/cash/z/ecc/android/sdk/internal/model/TransactionStatus.kt
Show resolved
Hide resolved
- New backend.transactionDataRequests and related logic is now used within CompactBlockProcessor - getTAddressTransactions from LightWalletclient module is now newly used - These also changes remove now unused querying transactions-related functions from v_transactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used both new FFI endpoints. I have two questions inline, though. @str4d, please.
backend-lib/src/main/java/cash/z/ecc/android/sdk/internal/model/JniTransactionDataRequest.kt
Outdated
Show resolved
Hide resolved
sdk-lib/src/main/java/cash/z/ecc/android/sdk/block/processor/CompactBlockProcessor.kt
Outdated
Show resolved
Hide resolved
sdk-lib/src/main/java/cash/z/ecc/android/sdk/block/processor/CompactBlockProcessor.kt
Outdated
Show resolved
Hide resolved
Instead of consuming the stream into list and working with list
558b509
to
d14a6b0
Compare
Handle setTransactionStatus by TransactionDataRequest rather then minedHeight
CompactblockProcessor.fetchTransaction
pass txId twice #1254Author
Reviewer
Footnotes
Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs. ↩
While we aim for automated testing of the SDK, some aspects require manual testing. If you had to manually test
something during development of this pull request, write those steps down. ↩
While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with:
./gradlew check
for Kotlin modules and./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true
for Android modules. ↩Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit. ↩
In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass. ↩
While the CI server runs the demo app to look for build failures or crashes, humans running the demo app are
more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally. ↩