2024 common #2
Merged
2024 common #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vichik123
force-pushed
the
2024-common
branch
from
08f93c3 to
8f01564
Compare
katzuv
reviewed
Dec 16, 2023
|
All of these changes can be made in the phoenix 6 branch, Emma will take care of most, and I of the rest the next chance we have. |
|
Even better actually, we can merge the phoenix 6 branch with its relevant changes, and then make all of these changes on this branch. |
|
Try the example I linked or post on the Phoenix beta thread on Chief
Delphi, it should work.
…On Sun, Dec 17, 2023, 12:27 vichik ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On src/main/java/lib/motors/TalonFXSim.java
<#2 (comment)>:
The TalonFXSimState didn't change.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHS2YZLVJR5F27SO2JWX7ZTYJ3CIRAVCNFSM6AAAAABALN2OSOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBVGQYTMMBXGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Also, it's best to not pass JAR files around. The package should be published to some package manager, then added as a dependency to projects that need it. It's easy to set up with GitHub Actions, see the link above. |
katzuv
reviewed
Dec 31, 2023
very weird gains
katzuv
reviewed
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2024 common libraries.
These consist of the swerve drive, the utilities and the tests for all.