SIP-29: Snap Assets API #154
Conversation
| ): TokenConversionRate; | ||
| ``` | ||
|
|
||
| ### Fiat currency representation |
There was a problem hiding this comment.
We should create a CAIP for this
There was a problem hiding this comment.
This is a good point. This is technically CAIP-19, but with unregistered namespaces.
I started a discussion on the CAIPs repo, let's see what other think of it.
* add handlers and permission definition * update to use `snaps-sdk` * snap -> Snap * Add CAIP-19 ID reference in description and rename token to asset * Add chains caveat * fix typo * allow batching * add fungible reference to asset description * add appendix for fungible assets * fix typos * update rates handler to support batching * unify * rename `AssetUnit` to `FungibleAssetUnit`
| fungible: true; | ||
|
|
||
| // Base64 representation of the asset icon. | ||
| iconBase64: string; |
There was a problem hiding this comment.
Can this be an URL link to the icon?
There was a problem hiding this comment.
I think it has to be an icon, the static token icon server is going to return pngs
| ticker: string; | ||
|
|
||
| // Whether the asset is native to the chain. | ||
| native: boolean; |
There was a problem hiding this comment.
How can we identify other types of tokens that need to be handled differently?
There was a problem hiding this comment.
Some examples might be differentiating between brc-20 and rune tokens on bitcoin. Or eth, erc20s, and staking contracts on ethereum. I anticipate more types of tokens than just native vs not. Not sure if anything built into caip19 already helps distinguish this.
| The type for an `onAssetConversion` handler function’s return value is: | ||
|
|
||
| ```typescript | ||
| type AssetConversionRate = { |
There was a problem hiding this comment.
How can we get historical market data?
It should be closer to the terminology used by the Token API.
No description provided.