Add modulefile for Dogwood/Cactus #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Cloned feature/wcoss2 on WCOSS2 (Cactus). Execute ./build.sh -v -f. Build failed with
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/bundle/ioda/src/engines/ioda/src/ioda/Engines/ReadScriptFile.cpp(25): error: no suitable constructor exists to convert from "\
double" to "std::variant<std::__cxx11::string, int, double>"
return std::stod(argValue);
^
compilation aborted for /lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/bundle/ioda/src/engines/ioda/src/ioda/Engines/ReadScriptFile.cpp (code 2)
This sounds like the IODA problem we are already aware of and are fixing.
danholdaway
previously approved these changes
Apr 25, 2024
RussTreadon-NOAA
previously approved these changes
Apr 25, 2024
|
I'll mark this as ready for review once I am able to update the submodules when the IODA pull request is merged in |
aerorahul
reviewed
Apr 26, 2024
added 2 commits
April 26, 2024 17:35
…into feature/wcoss2
CoryMartin-NOAA
dismissed stale reviews from RussTreadon-NOAA and danholdaway
via
60af1b2
CoryMartin-NOAA
added
hera-GW-RT
emcbot
added
hera-GW-RT-Running
RussTreadon-NOAA
approved these changes
Apr 26, 2024
|
Shall we try to run |
|
@RussTreadon-NOAA we can try, but as you note I expect it won't be trivial. I would suggest we tackle that in a subsequent PR. |
|
Simply loaded wcoss2.intel module and executed Errors are not surprising. |
|
Agreed. Let's merge this PR into |
|
@RussTreadon-NOAA yes, has been a long time coming! |
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Passed
danholdaway
added a commit
that referenced
this pull request
May 2, 2024
* develop: Visualize stats in simple html document (#1089) Time series of csv stats (#1086) Use the gdas bkg for the static B (#1084) Add module files to compile on AWS (#1082) The DA only uses the gdas bkg ... fixing again ... (#1079) Using ioda util to convert the datetime in AMSR2 converter (#1077) Add modulefile for Dogwood/Cactus (#1073) Addition of a switch for the cycling type (#1072) Added YAML, JSON, python files for assimilating VIIRS satwinds (#1055) No mpi for the ascii stats (#1070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we are technically not supposed to build our own CRTM or FMS, we are asking for forgiveness and forging ahead. This PR should allow GDASApp to compile on WCOSS2 (Dogwood and Cactus) after a minor issue is resolved. That issue being a compile issue in IODA that Ron is already aware of and has a fix that works (https://github.com/JCSDA-internal/ioda/compare/develop...bugfix/read_script_convert_fix).