-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kcl-cli: init at 0.8.5 #302488
kcl-cli: init at 0.8.5 #302488
Conversation
25fd393
to
e128119
Compare
c28ff1f
to
3bb2cf1
Compare
@ofborg eval |
I'm not entirely sure why |
Thank you! Can we retry it |
I don't think one can manually trigger this check. You might want to |
Signed-off-by: peefy <[email protected]>
@ofborg eval |
Thank you! I trigger the CI and it is still failed. |
Sorry, does anyone have more suggestions? It seems like the block is here. |
@ofborg eval |
@ofborg build |
@Aleksanaa Thank you! ❤️ |
Don't thank me, it doesn't work and I don't know why... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, 1 more change:
PR and commit title now need to be kcl-cli: ...
.
Then this is good to merge imo.
Signed-off-by: peefy <[email protected]>
Thank you! Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I have noticed that all the CI has been approved. Will it merge with the near future? |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.