Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graalvm-oracle: init at 22 #321026
base: master
Are you sure you want to change the base?
graalvm-oracle: init at 22 #321026
Changes from 8 commits
c0003d1
f5fb339
431d757
c7d75e3
4e10a9a
2cb3ab1
fdf484e
dadac9a
95c5bbb
b53a34d
f6a29e8
5a3da06
2e3ddbb
ef0f803
6aa74a7
8076fdc
0d16cb3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 2 in pkgs/development/compilers/graalvm/default.nix
GitHub Actions / exp-nixf-tidy-check
sema-def-not-used
Check failure on line 3 in pkgs/development/compilers/graalvm/default.nix
GitHub Actions / exp-nixf-tidy-check
sema-def-not-used
Check failure on line 5 in pkgs/development/compilers/graalvm/default.nix
GitHub Actions / exp-nixf-tidy-check
sema-def-not-used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these hashes are correct, I calculated them with nix-prefetch-url but I need to double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this URL is deterministic, there is no
/archive/
version for theseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the usage of
recurseIntoAttrs
here, we probably need to introduce a scope insidegraalvmPackages
to ensure that all packages are build with the same scope.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with scopes and not sure what this means. I tried just removing
recurseIntoAttrs
and things seem to work all the same, so it seems it can be safely dropped?Is the fact that
pkgs/development/compilers/graalvm/graalvm-oracle/default.nix
usesgraalvmPackages.buildGraalvm
(from the parent "scope"?) problematic?