Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch: expose extra GatewayIO for FPGA #513

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Batch: expose extra GatewayIO for FPGA #513

merged 3 commits into from
Nov 25, 2024

Conversation

xiaokamikami
Copy link
Contributor

When using FPGA diff, the batch data interface is brought to the gateway top-level
Co-authored-by: zhangshoulin [email protected]

@xiaokamikami xiaokamikami marked this pull request as ready for review November 25, 2024 10:35
@xiaokamikami xiaokamikami requested a review from klin02 November 25, 2024 10:36
if (!config.isFPGA) {
GatewaySink.batch(Batch.getTemplate, control, batch.io, config)
} else {
GatewaySink.fpga_batch(batch.enable, control, batch.io, config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If original GatewaySink.batch is not called, how can you get generated Cpp function like difftest_batch.

@klin02 klin02 changed the title Diff: fpga-difftest batch io out Batch: expose extra GatewayIO for FPGA Nov 25, 2024
@klin02 klin02 merged commit 546f1c7 into master Nov 25, 2024
5 checks passed
@klin02 klin02 deleted the base-of-zsl branch November 25, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants