sensors: add vehicle_angular_acceleration #14034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm open to suggestions if anyone would like to merge these into a single message. |
dagar
force-pushed
the
pr-vehicle_angular_acceleration
branch
from
9c11c2e to
35b96c8
Compare
jlecoeur
reviewed
Jan 27, 2020
src/modules/sensors/vehicle_angular_velocity/VehicleAngularVelocity.cpp
Outdated
Show resolved
Hide resolved
That was another little benefit to doing it this way. We can simply publish angular acceleration right before angular velocity and get away with it for now. |
…for angular acceleration
dagar
force-pushed
the
pr-vehicle_angular_acceleration
branch
from
a8ce9d6 to
ef8d608
Compare
jlecoeur
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jlecoeur I was going to bring in sensors/vehicle_angular_acceleration from #13219, but a lot of the duplicate structure started to seem a bit wasteful compared to doing it in place next to angular velocity.
This also sets us up for using the raw FIFO data later (PX4/PX4-ECL#621 (comment)) if desired.