Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter migration: code cleanup, migration script, and land_detector trial #19489

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
+15,380 −23,006
Open

Parameter migration: code cleanup, migration script, and land_detector trial #19489

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
108602b
tools/validate_yaml: code cleanup
coderkalyan Apr 14, 2022
1292fdc
tools/validation: allow json with cerberus for future migration
coderkalyan Apr 14, 2022
179255b
parameters: srcparser code cleanup
coderkalyan Apr 14, 2022
9e9a087
land_detector: migrate c parameter definitions to yaml
coderkalyan Apr 14, 2022
935d277
src/modules: parameter format migration (WIP)
coderkalyan Jul 13, 2022
0817791
tools: add migrate_c_params helper script
coderkalyan Apr 14, 2022
7358465
tools/generate_params: fix boolean property bug
coderkalyan Jul 14, 2022
4b6179f
modules: migrate all modules to yaml parameter definitions
coderkalyan Jul 14, 2022
a5ffbe7
drivers: migrate all drivers to yaml parameter definitions
coderkalyan Jul 14, 2022
dfbb110
python/pip: add requirements.txt
coderkalyan Jul 14, 2022
5cad5c2
validation: add new units and increase short description length
coderkalyan Jul 14, 2022
22ff3b3
ci: temporarily add dataclasses dependency
coderkalyan Jul 16, 2022
7fe65c6
battery: capitalize parameter category
coderkalyan Jul 18, 2022
066ac8a
tools/generate_config: fix empty default value bug
coderkalyan Jul 20, 2022
ed941e7
parameters: update injected parameter descriptions
coderkalyan Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/clang-tidy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,8 @@ jobs:
with:
token: ${{secrets.ACCESS_TOKEN}}

- name: install dependencies
run: pip3 install dataclasses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px4params/scrparser.py. When I wrote that I was targeting Python 3.7 compatibility since that's the oldest "supported" Python but I then realized we use 3.6 in some places. This is backwards compatibility for 3.6, dataclasses are built into 3.7+

Daniel and I decided to add it directly here because the bionic docker containers aren't behaving (unrelated to my changes) and I couldn't build a new one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO worth adding a comment in the file or commit message, so we can remove it later on.


- name: make clang-tidy-quiet
run: make clang-tidy-quiet
3 changes: 3 additions & 0 deletions .github/workflows/mavros_mission_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ jobs:
ccache -s
ccache -z

- name: install dependencies
run: pip3 install dataclasses

- name: check environment
run: |
export
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/mavros_offboard_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ jobs:
ccache -s
ccache -z

- name: install dependencies
run: pip3 install dataclasses

- name: check environment
run: |
export
Expand Down