-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIM: MPC: add two x500 lidar airframes #23879
Conversation
…r sensors and their orientation
f43eeec
to
ef72892
Compare
Co-authored-by: Jacob Dahl <[email protected]>
Co-authored-by: Jacob Dahl <[email protected]>
For docs, we want to know how they are used/invoked, what they allow you to test when using that frame (such as terrain following, collision detection etc) [i.e. if enabled by default], and any limits - i.e. rangefinder max/min distance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me!
Just a question, is it possible to have both a 2d lidar and a lidar for a distance sensor?
@Jaeyoung-Lim yea. This should be possible, as the two publish to different topics, and GZBridge is able to differentiate them by that. |
Partly Tracked in #23602
To be merged only when following PR is merged
other relevant PR's
Overview
This PR Adds two X500 models, one with a front facing rangefinder for collision prevention, and one down facing lidar for normal rangefinder use case testing.
I also renamed the x500_lidar to x500_lidar_2d, to better differentiate the three
Changes:
New Models:
x500_lidar_front
x500_lidar_front
Changes:
x500_lidar
-->x500_lidar_2d
Changelog Entry
For release notes:
Test coverage
Open Tasks: