Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIM: MPC: add two x500 lidar airframes #23879

Merged
merged 4 commits into from
Nov 13, 2024
Merged

SIM: MPC: add two x500 lidar airframes #23879

merged 4 commits into from
Nov 13, 2024

Conversation

Claudio-Chies
Copy link
Contributor

@Claudio-Chies Claudio-Chies commented Nov 1, 2024

Partly Tracked in #23602
To be merged only when following PR is merged

other relevant PR's

Overview

This PR Adds two X500 models, one with a front facing rangefinder for collision prevention, and one down facing lidar for normal rangefinder use case testing.
I also renamed the x500_lidar to x500_lidar_2d, to better differentiate the three

Changes:

New Models:
x500_lidar_front
x500_lidar_front
Changes:
x500_lidar --> x500_lidar_2d

Changelog Entry

For release notes:

Feature: Added front and downfacing MPC Models for SITL Testing
Documentation: read docs.px4.io/main/en/sim_gazebo_gz/vehicles.html

Test coverage

  • Tested in SITL

Open Tasks:

  • Update the Docs
  • Update the Git Submodules, once the models have been merged.
  • Add Meshes to the sensors.

@Claudio-Chies Claudio-Chies added Simulation Sim: gazebo Gazebo simulator (gz) labels Nov 1, 2024
@Claudio-Chies Claudio-Chies marked this pull request as ready for review November 4, 2024 09:54
@Claudio-Chies Claudio-Chies force-pushed the pr-x500_lidar_airframes branch from f43eeec to ef72892 Compare November 4, 2024 10:08
@dakejahl dakejahl enabled auto-merge (squash) November 5, 2024 07:58
@hamishwillee
Copy link
Contributor

For docs, we want to know how they are used/invoked, what they allow you to test when using that frame (such as terrain following, collision detection etc) [i.e. if enabled by default], and any limits - i.e. rangefinder max/min distance.

Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me!

Just a question, is it possible to have both a 2d lidar and a lidar for a distance sensor?

@dakejahl dakejahl merged commit d14c054 into main Nov 13, 2024
54 of 56 checks passed
@dakejahl dakejahl deleted the pr-x500_lidar_airframes branch November 13, 2024 07:44
@Claudio-Chies
Copy link
Contributor Author

@Jaeyoung-Lim yea. This should be possible, as the two publish to different topics, and GZBridge is able to differentiate them by that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sim: gazebo Gazebo simulator (gz) Simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants