Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: always log can_interface_status #24071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dakejahl
Copy link
Contributor

@dakejahl dakejahl commented Dec 3, 2024

There's a caveat with LoggedTopics::add_optional_topic, it will fail to log topics that don't exist at the time of the logger instantiation. So any sensor that publishes later (CAN nodes for example) won't be logged. Namely the newish CanInterfaceStatus message, the status of the CAN interfaces is not logged since a CAN node will typically take longer to boot than the FC does.

@dakejahl dakejahl requested a review from dagar December 3, 2024 23:57
@mrpollo mrpollo force-pushed the pr-always_log_can_interface_status branch from b312338 to 39708cb Compare December 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant