-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing CBAT message #24088
Draft
sdomoszlai13
wants to merge
11
commits into
PX4:main
Choose a base branch
from
sdomoszlai13:add-cbat-msg-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+149
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0540010
to
6efa3fa
Compare
sdomoszlai13
commented
Jan 29, 2025
1ad3ed4
to
647dc5a
Compare
sdomoszlai13
commented
Jan 29, 2025
sdomoszlai13
commented
Jan 29, 2025
sdomoszlai13
commented
Jan 29, 2025
5b40c2e
to
b37736c
Compare
a713d88
to
3b83bb4
Compare
3b83bb4
to
c18dc6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for parsing CUAV's CBAT message in order to read serial numbers of certain smart batteries (e.g. Tattu).
Solved Problem
When trying to read the serial number of a Tattu smart battery, I found that the battery sends a CBAT message that contains valuable info about it (e.g., the serial number) but isn't parsed currently in PX4. To get the info in the message, the pasing logic is added in this PR.
Fixes #{Github issue ID}
Solution
Changelog Entry
For release notes:
Alternatives
We could also ...
Test coverage
Context
Related links, screenshot before/after, video