[wip] gz plugins #24153
Draft
[wip] gz plugins #24153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, we should bundle gz plugins with the gz models, since this is how gz is designed. IMHO, gz bridge should support generic messages, not specific to plugins. Given that said, I quite disliked how gz classic models and plugins were a submodule, but cannot think of a better alternative @dagar Any opinions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds build infrastructure for gz plugins. I've implemented an optical flow sensor plugin and created a model for it.
In my opinion we should tightly couple the gz_bridge with gz_plugins, since the gz_bridge needs to subscribe to our custom proto msgs and publish to uorb.
Looking for feedback and help with restructuring the build.
Should we follow the same design as gazebo classic and bundle this all up into a submodule?