Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc.sensors: try starting iis2mdc #24254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexKlimaj
Copy link
Member

The new ARK SAM GPS uses the iis2mdc over I2C directly.

@AlexKlimaj AlexKlimaj requested a review from dagar January 24, 2025 22:54
@dakejahl
Copy link
Contributor

I recently discovered that the lis2mdl and iis2mdc are identical from a software perspective. Do we want to keep both drivers around @dagar? This means running the iis2mdc driver will detect an lis2mdl as an iis2mdc
https://www.st.com/resource/en/design_tip/dt0131-digital-magnetometer-and-ecompass-efficient-design-tips--stmicroelectronics.pdf

@dagar
Copy link
Member

dagar commented Jan 27, 2025

If they're actually identical we can't really be probing both here.

Literally identical 100% or any actual differences?

@AlexKlimaj
Copy link
Member Author

Sounds like identical from a firmware perspective. But I think the actual manufacturing of the MEMs is different.

@AlexKlimaj
Copy link
Member Author

It looks like the lis2mdl isn't included in common magnetometers. I've updated rc.sensors to try starting the iis2mdc first, then trying the lis2mdl if it fails.

@dakejahl
Copy link
Contributor

dakejahl commented Feb 3, 2025

I think ideally we'd have only one driver, but I wrote the iis2mdc because I didn't even realize they were the same part. So maybe ideally one driver with a nice comment at the top referencing the support for those multiple devices. And then we delete the duplicate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants