Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simkin modular merge #11

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Simkin modular merge #11

wants to merge 2 commits into from

Conversation

alfredsimkin
Copy link
Collaborator

made small modifications to schema.json to facilitate MIP files
wrapped sections of merge into functions
added an 'init' block
changed output folder from 'PMO' to 'finished_PMO_files'

I didn't wrap the functions into classes - I can do this if it would be helpful for consistency with the other pages (left it this way because I think readability is better, but maybe there are advantages to implementing as classes that I'm unfamiliar with - I'd like to learn more about it)

@kathryn1995 kathryn1995 self-requested a review February 19, 2025 01:19
@kathryn1995
Copy link
Contributor

This looks so much neater, thanks Alfred!

When I build the app I am seeing these errors when the panel info and bioinformatics info aren't entered yet:
Screenshot 2025-02-20 at 3 37 12 PM
Screenshot 2025-02-20 at 3 38 06 PM

I'm also wondering if the check functions could be made into one more general function as they have the same pattern?

@kathryn1995
Copy link
Contributor

Also, what formatter are you using for your code? We seem to have some conflicts between what we're using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants