tla2528 driver #12
tla2528 driver #12
Conversation
| void application(application_framework& p_framework) | ||
| { | ||
|
|
||
| hal::byte i2c_address = 0x10; // 0x10 is the tla address for no resistors |
There was a problem hiding this comment.
Why must the user pass this in if this is the default? Why not make the constructor have a default parameter that sets the address to 0x10 and the dev can change this if they need to change it.
There was a problem hiding this comment.
0x10 is a default parameter. For the demos, I put the address at the top for ease of access, as that way, people aren't wondering how to change the address if they just want to test their TLA and they have it wired to a different address.
There was a problem hiding this comment.
This is probably best to remove. If the constructor doesn't describe in detail how the i2c address works, it should so anyone reading the header can see exactly when they'd need to use a differnt address.
There was a problem hiding this comment.
updated documentation & removed address from demos, look it over
drivers/src/tla2528.cpp
Outdated
| uint16_t data = 0; | ||
| hal::bit_modify(data).insert<hal::bit_mask::from(4, 11)>(data_buffer[0]); | ||
| hal::bit_modify(data).insert<hal::bit_mask::from(0, 3)>( | ||
| hal::bit_extract(hal::bit_mask::from(4, 7), data_buffer[1])); | ||
| return data / 4095.0; |
There was a problem hiding this comment.
Give the bit masks names so its easier to understand what they are.
Split up the bit_extract into its own named variable so its easier to distinguish against the rest of the code here.
There was a problem hiding this comment.
updated according to the conversation we had, using manual bit op and added a comment pointing to the datasheet.
There was a problem hiding this comment.
Looks great. The last comments are for docs and TODO comments. After those are fixed up, this should be merged 😄
Great work @MichaelYKersey ! I know this took a very long time and a lot of effort!
MichaelYKersey
force-pushed
the
TLA2528
branch
from
d038b36 to
2b074b8
Compare
tla2528 driver and wrappers are working and tested only a few features are still to implemented:
CRC for data validationchannel id confirmation