Add support for RHCloud Cloud Connector #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
mstrlc
force-pushed
the
rhcloud_enable_connector
branch
from
7eb0911
to
71ec19f
Compare
mstrlc
added
CherryPick
Griffin-Sullivan
previously approved these changes
May 8, 2023
ogajduse
requested changes
May 17, 2023
Co-authored-by: Ondřej Gajdušek <[email protected]>
jameerpathan111
previously approved these changes
Jun 7, 2023
vsedmik
previously approved these changes
Jun 16, 2023
ogajduse
requested changes
Jun 20, 2023
ogajduse
approved these changes
Jun 21, 2023
jameerpathan111
approved these changes
Jun 21, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
* add support for RHCloud Cloud Connector * remove location_id and organization_id from args * add Nailgun tests * add Nailgun tests * update entity fields Co-authored-by: Ondřej Gajdušek <[email protected]> * change the way data are passed to the function * change the way data are passed to the function * update test to match change --------- Co-authored-by: Ondřej Gajdušek <[email protected]> (cherry picked from commit 13c0375)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
* add support for RHCloud Cloud Connector * remove location_id and organization_id from args * add Nailgun tests * add Nailgun tests * update entity fields Co-authored-by: Ondřej Gajdušek <[email protected]> * change the way data are passed to the function * change the way data are passed to the function * update test to match change --------- Co-authored-by: Ondřej Gajdušek <[email protected]> (cherry picked from commit 13c0375)
mstrlc
added a commit
to mstrlc/nailgun
that referenced
this pull request
Jun 21, 2023
* add support for RHCloud Cloud Connector * remove location_id and organization_id from args * add Nailgun tests * add Nailgun tests * update entity fields Co-authored-by: Ondřej Gajdušek <[email protected]> * change the way data are passed to the function * change the way data are passed to the function * update test to match change --------- Co-authored-by: Ondřej Gajdušek <[email protected]> (cherry picked from commit 13c0375)
ogajduse
pushed a commit
that referenced
this pull request
Jun 21, 2023
* add support for RHCloud Cloud Connector * remove location_id and organization_id from args * add Nailgun tests * add Nailgun tests * update entity fields Co-authored-by: Ondřej Gajdušek <[email protected]> * change the way data are passed to the function * change the way data are passed to the function * update test to match change --------- Co-authored-by: Ondřej Gajdušek <[email protected]> (cherry picked from commit 13c0375)
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds Nailgun support for RHCloud Cloud Connector API.
Functional demonstration
This feature is tested with Robottelo test tests/foreman/api/test_rhc.py::test_positive_configure_cloud_connector,
see SatelliteQE/robottelo#11395 PRT run.
Additional Information
Nailgun tests addded and passing.