Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add GitHub actions per tool #45

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Feature/add GitHub actions per tool #45

wants to merge 21 commits into from

Conversation

ellendejong
Copy link
Collaborator

@ellendejong ellendejong commented Sep 17, 2024 •
edited
Loading

What has changed?

  • Added Github workflow actions per tool.
    By using path filters, a wokflow runs based on what file paths are changed.
  • Use pytest-datadir to group test data together in GenderCheck and MosaicHunter. Pytest-datadir will detect dir with the name of your module (used in this PR) or global name 'data'.
  • Lint updates in Util scripts.

rernst
rernst requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit, wat kleine implementatie opmerkingen / vragen.

.github/workflows/checkqc_lint.yml Outdated Show resolved Hide resolved
.github/workflows/checkqc_lint.yml Show resolved Hide resolved
CheckQC/pyproject.toml Outdated Show resolved Hide resolved
CheckQC/pyproject.toml Outdated Show resolved Hide resolved
GenderCheck/test_calculate_gender.py Show resolved Hide resolved
GenderCheck/pyproject.toml Outdated Show resolved Hide resolved
MosaicHunter/1.0.0/pyproject.toml Show resolved Hide resolved
Utils/create_hsmetrics_summary.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@rernst rernst mentioned this pull request Sep 26, 2024
Open
rernst
rernst requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nog 1 laatste opmerking over paths bij 'on' config van github actions.

.github/workflows/checkqc_lint.yml Show resolved Hide resolved
rernst
rernst previously approved these changes Sep 30, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rernst rernst rernst left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellendejong @rernst