Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.9.0 #79

Merged
merged 39 commits into from
Mar 14, 2024
Merged

v1.9.0 #79

merged 39 commits into from
Mar 14, 2024

Conversation

rernst
Copy link
Member

@rernst rernst commented Feb 23, 2024

rernst and others added 29 commits October 3, 2023 16:29
@rernst
Merge pull request #68 from UMCUGenetics/release/v1.8.0
c5bed7b 
Release/v1.8.0
@rernst
Merge pull request #70 from UMCUGenetics/hotfix/v1.8.1
503d171 
Hotfix/v1.8.1
@ellendejong
Merge pull request #72 from UMCUGenetics/hotfix/v1.8.2
ace575e 
Hotfix/v1.8.2 to develop
@rernst
Merge pull request #74 from UMCUGenetics/hotfix/v1.8.3
24cd76a 
Hotfix/v1.8.3 to develop
@rernst
Merge pull request #76 from UMCUGenetics/hotfix/v1.8.4
ee4b19e 
Hotfix/v1.8.4 to develop
@rernst
WIP, new samplesheet writer.
c217533
@rernst
Add orientation fixes
824434f
@rernst
Add orientation fixes
18d322c
@rernst
Remove old update samplesheet code
e816fc2
@rernst
Update sequencing workflow
eeb11c4
@rernst
Add illumina tests
890feda
@rernst
Move to get_sample_sequence_index to utils and test
2b45a43
@rernst
Enable unit test @ master
0d33a9a
@rernst
Fix for single index samples
20e8018
@rernst
Add some extra fields
1dc667d
@rernst
Add 0 Mismatches setting for barcodes
163d21e
@rernst
Code review changes
67f35c6
@rernst
Layout
02fe411
@rernst
Add indications_exome_equivalent
0c5ee77
@rernst
Merge pull request #78 from UMCUGenetics/feature/deep_seq_import
a1d0f38 
Support for deep sequencing imports
@rernst
Merge branch 'develop' into feature/illumina_samplesheet_v2
8715904
@rernst
Change volume
94848db
@rernst
Add extra required conversion settings
6ccd9cd
@rernst
Tweaks based on lab input
4bf19f0
@rernst
python3
9431630
@rernst
python3
f40ed38
@rernst
Remove debug prints
9192ec4
@rernst
Merge pull request #77 from UMCUGenetics/feature/illumina_samplesheet_v2
97a16df 
Feature/illumina samplesheet v2
@rernst
Merge branch 'develop' into release/v1.9.0
42961c5
@melferink melferink self-requested a review February 23, 2024 14:23
melferink
melferink previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@melferink melferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Al commits are approved before

@rernst rernst requested a review from melferink March 1, 2024 14:59
@melferink melferink self-requested a review March 4, 2024 08:59
melferink
melferink previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@melferink melferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, remark about code duplication will be solved in the (near) future.

@melferink melferink self-requested a review March 11, 2024 06:21
melferink
melferink approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@melferink melferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved
NovaSeqXPlus fix is fine for now regarding the TODO's

@melferink melferink mentioned this pull request Mar 12, 2024
Merged
@rernst rernst merged commit f9ee045 into master Mar 14, 2024
2 checks passed
@rernst rernst deleted the release/v1.9.0 branch March 14, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melferink melferink melferink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rernst @melferink @ellendejong