Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly renaming and organizing Assignments. #13

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danielrazavi
Copy link
Member

@danielrazavi danielrazavi commented May 28, 2024

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

The assignments are now numbered in order.

Assignment dependency files and the assignments markdown files have been placed in their respective folders.

Note: I'm not sure if final assessment should be labeled a5 or not. @zogheibc can you please advise?

ALSO:

the entire repo file structure has been changed a little bit to be more similar to the other repos. This was done in another PR but they have been reflected here due to a merge conflict.

Checklist

  • I can confirm that my changes are working as intended

@danielrazavi danielrazavi requested review from zogheibc, curtissfnorman and RohanAlexander and removed request for RohanAlexander May 28, 2024 19:48
RohanAlexander
RohanAlexander previously approved these changes Jun 4, 2024
@RohanAlexander
Copy link
Member

@curtissfnorman - can you please look at this one. I made a change and so can't approve it again.

curtissfnorman
curtissfnorman previously approved these changes Jun 5, 2024
@danielrazavi
Copy link
Member Author

@zogheibc can you please take a look at this PR?

This PR is a little confusing as there was a merge conflict that needed to be addressed. I've updated the PR description to better explain what is going on.

The main question I had of you was that Sampling and Reproducibility in Python became A1 since that is apparently what we did in the last cohort. If that assignment is in fact A1, then the schedule table in the README needs to be updated, since we refer to this project in learning session 5, whereas other assignments have already happened before A1.

@zogheibc
Copy link
Collaborator

zogheibc commented Jun 5, 2024

H @danielrazavi - sampling and reproducibility in Python is assignment 1, yes. I know we discussed my re-adding activities to slides before, my plan is to do that (and review the current repo) after my break, so in July. Hopefully that timeline still works!

@danielrazavi
Copy link
Member Author

@zogheibc That sounds great to me! We'll keep this PR and branch open for you then.

@danielrazavi danielrazavi marked this pull request as draft June 5, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants