Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat fix #348

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Concat fix #348

merged 2 commits into from
Sep 27, 2023

Conversation

vhavlena
Copy link
Collaborator

@vhavlena vhavlena commented Sep 26, 2023

This PR fixes the concatenation problem.

@vhavlena vhavlena requested a review from kilohsakul September 26, 2023 17:39
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (069554c) 72.94% compared to head (e555504) 72.95%.
Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #348   +/-   ##
=======================================
  Coverage   72.94%   72.95%           
=======================================
  Files          33       33           
  Lines        4144     4145    +1     
  Branches      955      955           
=======================================
+ Hits         3023     3024    +1     
  Misses        740      740           
  Partials      381      381           
Files Coverage Δ
src/nfa/concatenation.cc 92.18% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Preallocates delta to have all initial and final states in delta as well. Only then you can append to delta.)

LGTM.

@Adda0 Adda0 merged commit 5331c53 into devel Sep 27, 2023
20 checks passed
@Adda0 Adda0 deleted the concat-fix branch September 27, 2023 06:57
@Adda0
Copy link
Collaborator

Adda0 commented Sep 27, 2023

The rest can do their review later and we will incorporate their suggestions in later PRs.

@vhavlena vhavlena mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants