Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats implementation #283

Closed
wants to merge 52 commits into from
Closed

Stats implementation #283

wants to merge 52 commits into from

Conversation

ikbalkaya
Copy link
Contributor

@ikbalkaya ikbalkaya commented Dec 21, 2021 •
edited
Loading

This PR includes full implementation of Rest.stats function for Flutter plugin. As stats is a slightly complicated and big object, this pull request might seem a bit huge but the scope is still just a map of a function.
Implemenation contains

  • New type definitions on Flutter side for code generation
  • New encoders for Java
  • New encoders for Swift/Objective-C
  • Function mappings
  • A paginated result viewer addition to example app.

There were some differences between native implementations

  • Structures were formed slightly differently. I created an issue in ably-java for this Stats structure is not fully compatible with spec ably-java#733
  • The way stats params were received was a bit more structured in Objective C than Java. In Objective C there is a dedicated object for this, where it's a Param[] in Java. I have created a separate category in Objective C to build that object from the map sent from Dart side.

@ben-xD
Add script to format all files
f517f65
@ben-xD
Improve steps for getting started with contributing
b13f4bb
@ben-xD
Remove unnecessary readme, since contents have been merged into main …
e676238 
…README
@ben-xD
Add emoji so each line is clearer
715902d
@ben-xD
Add removed section
18586a8
@ben-xD
Add formatting checks for Swift and Java
53504a3
@ben-xD
Use macos & brew instead of ubuntu & mint
df021bd
@ben-xD
Rename job
8551b4d
@ben-xD
Introduce some temporary formatting issues to confirm all formatting …
9ad8441 
…checks fail
@ben-xD
Update args for java formatter
d919523
@ben-xD
Revert "Introduce some temporary formatting issues to confirm all for…
01ce781 
…matting checks fail"

This reverts commit 9ad8441.
@ben-xD
Introduce formatting issue in Swift to test CI formatter
9ea9f6f
@ben-xD
Add checkout action
04f8be8
@ben-xD
Revert "Introduce formatting issue in Swift to test CI formatter"
f76909d 
This reverts commit 9ea9f6f.
@ben-xD
Add pre-commit hook and guidance on how to use it
d963fda
@ben-xD
Add note about SourceTree
c238016
@ben-xD
Remove outdated comment
23104b7
@ben-xD
Update message
252e1ce
@ben-xD
Rename .githooks directory to hooks
cd69001
@ben-xD
Check android files only, to avoid checking formatting for dependen…
80b6265 
…cies and example app
@ben-xD
Move dependency checks into a separate file
0689c36
@ben-xD
Replace emojis with simpler messages
ba7f505
@ben-xD
Allow scripts to be run from any directory
12a10db
@ben-xD
Remove whitespace in log lines
21f7e42
@ben-xD
Replace bash with source in script
57acd83
@ben-xD
Use emoji to be clearer
828ce6f
@ben-xD
Elaborate on device deactivation documentation
38afe16
@ben-xD
Improve error message if google-java-format is not installed
abb0dfc
@ben-xD
Elaborate on run/debug and formatting scripts
0fe71e9
@ben-xD
Only attempt to format/lint source code files, avoiding symlinked fil…
a4bf72c 
…es provided by other pods
@github-actions github-actions bot temporarily deployed to staging/pull/283/dartdoc December 21, 2021 17:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/283/dartdoc December 22, 2021 15:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/283/dartdoc December 22, 2021 16:08 Inactive
@ikbalkaya ikbalkaya mentioned this pull request Dec 23, 2021
Open
@github-actions github-actions bot temporarily deployed to staging/pull/283/dartdoc December 23, 2021 11:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/283/dartdoc December 23, 2021 12:18 Inactive
@ikbalkaya ikbalkaya self-assigned this Dec 23, 2021
@ikbalkaya ikbalkaya added the enhancement New feature or improved functionality. label Dec 23, 2021
@ikbalkaya ikbalkaya marked this pull request as ready for review December 23, 2021 16:04
@ikbalkaya ikbalkaya removed the request for review from tiholic December 23, 2021 16:04
@ikbalkaya ikbalkaya linked an issue Dec 29, 2021 that may be closed by this pull request
Implement stats Rest and Realtime clients #260
Closed
@ikbalkaya ikbalkaya mentioned this pull request Jan 5, 2022
Open
@ikbalkaya ikbalkaya linked an issue Jan 5, 2022 that may be closed by this pull request
REST and Realtime Statistics (Stats) #106
Open
ikurek
ikurek approved these changes Feb 1, 2022
View reviewed changes
bin/README.md
@@ -1,47 +0,0 @@
## Code generation to keep platform constants in sync
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removed purposely? I think it may be usefull 🤔

@ikurek ikurek mentioned this pull request Feb 8, 2022
Draft
@ikurek
Copy link
Contributor

ikurek commented Feb 8, 2022

Closing this in favor of #324

@ikurek ikurek closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikurek ikurek ikurek approved these changes

@QuintinWillison QuintinWillison Awaiting requested review from QuintinWillison

Assignees

@ikbalkaya ikbalkaya

Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REST and Realtime Statistics (Stats) Implement stats Rest and Realtime clients
3 participants
@ikbalkaya @ikurek @ben-xD