Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats function implementation #324

Draft
wants to merge 52 commits into
base: main
Choose a base branch
from
Draft

Stats function implementation #324

wants to merge 52 commits into from

Conversation

ikurek
Copy link
Contributor

@ikurek ikurek commented Feb 8, 2022

This is a rework of #283 because the previous PR was made from enhancement/formatting and the branch can't be merged. The logic had to be extended, since the solution presented in previous PR didn't work.

Original description from #283:

This PR includes full implementation of Rest.stats function for Flutter plugin. As stats is a slightly complicated and big object, this pull request might seem a bit huge but the scope is still just a map of a function.
Implemenation contains

  • New type definitions on Flutter side for code generation
  • New encoders for Java
  • New encoders for Swift/Objective-C
  • Function mappings
  • A paginated result viewer addition to example app

There were some differences between native implementations:

  • Structures were formed slightly differently. I created an issue in ably-java for this
  • Stats structure is not fully compatible with spec ably-java#733

The way stats params were received was a bit more structured in Objective C than Java. In Objective C there is a dedicated object for this, where it's a Param[] in Java. I have created a separate category in Objective C to build that object from the map sent from Dart side.

Additions from my side:

  • Removed unnecessary formatting and changes
  • Fixed issue with null handle being passed to iOS method
  • Implemented dart decoder for Stats objects

This pull request remains blocked untill ably-java#733 and ably-cocoa#1284 are resolved, so I'm leaving it as a draft

ikbalkaya and others added 30 commits February 8, 2022 18:20
@ikbalkaya @ikurek
Generated constants for realtimeTime
e2aab9b
@ikbalkaya @ikurek
Time function implemenation in Dart side
8022b67
@ikbalkaya @ikurek
Java / Android side implementation of time
d56ff4d
@ikbalkaya @ikurek
IOS/objective C implementation of realtimeTime
95942a5
@ikbalkaya @ikurek
Added time information to realtime_sliver.dart
5463f49
@ikbalkaya @ikurek
Replaced realtimeTime with time (codegen)
5b7c684
@ikbalkaya @ikurek
Updated platform references to time
1a1f961
@ikbalkaya @ikurek
Renamed method to time in Java
78c7621
@ikbalkaya @ikurek
Updated refercen name to _time
2662612
@ikbalkaya @ikurek
Implemented time function in rest.dart
7b83e0f
@ikbalkaya @ikurek
Added rest time to UI
f6fafeb
@ikbalkaya @ikurek
Used getAblyClient to get the rest instance
2a3b4c8
@ikbalkaya @ikurek
Add code to be able to switch between rest/realtime for objective-c code
f99dcca
@ikbalkaya @ikurek
Code formatting
a16be43
@ikbalkaya @ikurek
Code formatting for rest.dart and realtime.dart
f23f523
@ikbalkaya @ikurek
Made explicit differences between restTime and realtimeTime
1719a4a
@ikbalkaya @ikurek
Split realtimeTime and restTime in two methods Android id side
ea9315f
@ikbalkaya @ikurek
Split realtimeTime and restTime in two methods iOSside
c570f08
@ikbalkaya @ikurek
Flutter format
dcaf6d0
@ikurek
Regenerated platform constants for time function
15a743c
@ikurek
Fixed time methods code smells, added missing AblyBase import
41f2d41
@ikurek
Fixed restTime method message handling on iOS side
38df5e5
@ikbalkaya @ikurek
Made explicit differences between restTime and realtimeTime
4457a5e
@ikbalkaya @ikurek
Codegen for realtime stats
cdc153c
@ikbalkaya @ikurek
Stats encoding from Android side
8249b95
@ikbalkaya @ikurek
Moved stats mapping from realtime to rest
fdd3027
@ikbalkaya @ikurek
File formatting
e588837
@ikbalkaya @ikurek
Created StatsEncoder for iOS
8a18f25
@ikbalkaya @ikurek
Stats encoding mappings in Obj-C
8fc48e2
@ikbalkaya @ikurek
Fix function calls in StatsEncoders
d04a956
@ikurek
Removed leftover realtime stats widget
f48023e
@ikurek
Regenerated platform constants
8bf9837
@ikurek
Added Java message codec support for Stats message type
c902a1e
@ikurek
Implemented basic methods for decoding Stats JSON object
c130b31
@ikurek
Reduced Stats count fetched in example app
d66e5aa
@ikurek
Removed unnecessary formatting changes from AblyMessageCodec to make …
0e7ad6a 
…the PR readable
@ikurek
Moved stats to proper category in codegen_context
2031824
@ikurek
Added serialization method for StatsRequestCount
b211abd
@ikurek
Added serialization method for StatsMessageTypes, fixed Android issue…
749c2cf 
… with serializing Stats.MessageCategory
@ikurek
Added serialization method for StatsConnectionTypes
38a2918
@ikurek
Added serialization method for StatsMessageTraffic
f54f6f5
@ikurek
Fixed tokenrequest serialization on dart side
ca14d9c
@ikurek
Added decoding StatsMessageTypes for persisted field
289d451
@ikurek
Fixed stats method message handling on iOS side
9ad87dc
@ikurek ikurek added enhancement New feature or improved functionality. blocked-by-ably-cocoa labels Feb 8, 2022
@ikurek ikurek self-assigned this Feb 8, 2022
@ikurek ikurek changed the base branch from main to feature/time-function February 8, 2022 17:36
@ikurek ikurek changed the title Stats function Stats function implementation Feb 8, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/324/dartdoc February 8, 2022 17:38 Inactive
@ikurek ikurek mentioned this pull request Feb 8, 2022
Closed
@ikurek ikurek linked an issue Feb 9, 2022 that may be closed by this pull request
Implement stats Rest and Realtime clients #260
Closed
@ably-sync-bot ably-sync-bot mentioned this pull request Feb 9, 2022
Closed
Base automatically changed from feature/time-function to main February 25, 2022 13:40
@ikurek ikurek mentioned this pull request Feb 25, 2022
Open
@QuintinWillison QuintinWillison added blocked-by-ably We can't proceed until something under our direct control, in a different codebase, happens. and removed blocked-by-ably-cocoa labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ikurek ikurek

Labels
blocked-by-ably We can't proceed until something under our direct control, in a different codebase, happens. enhancement New feature or improved functionality.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement stats Rest and Realtime clients
3 participants
@ikurek @QuintinWillison @ikbalkaya