introduce ImageModifier #32876

stephane-airbyte · 2023-11-28T16:44:16Z

using enum instead of strings for postgres container modifiers

vercel · 2023-11-28T16:44:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Dec 7, 2023 7:40pm

stephane-airbyte · 2023-11-28T16:44:25Z

Current dependencies on/for this PR:

master
- PR introduce PostgresBaseImage #32851
  - PR introduce ImageModifier #32876 👈
    - PR introduce BaseImage for MsSql #32897
      - PR introduce ImageModifier to MS SQL source #32898
        
        PR introduce BaseImage to MySql source #32899
        
        PR introduce ImageModifier to MySql source #32900
        
        PR removing POSTGRES_16_ALPINE base image #32948
        
        PR simplify MSSQL images #32951
        
        PR simplify postgres base images #32952
        PR rename getImageModifiers into getContainerModifiers everywhere #32958

This stack of pull requests is managed by Graphite.

github-actions · 2023-11-28T16:44:37Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

postamar · 2023-11-29T00:54:37Z

...gres/src/testFixtures/java/io/airbyte/integrations/source/postgres/PostgresTestDatabase.java

@@ -36,8 +36,27 @@ public static enum BaseImage {

  }

-  static public PostgresTestDatabase in(BaseImage imageName, String... methods) {
-    final var container = new PostgresContainerFactory().shared(imageName.reference, methods);
+  public static enum ImageModifier {


This might be pedantic but this should be named ContainerModifier. We're not modifying the image.

postamar · 2023-11-29T00:58:35Z

...gres/src/testFixtures/java/io/airbyte/integrations/source/postgres/PostgresTestDatabase.java

+    ImageModifier(String methodName) {
+      this.methodName = methodName;
+    }
+


Suggestion: add a method apply (or whatever) which actually does the thing instead of naming a method in PostgresContainerFactory. You could pass a Consumer<GenericContainer<?>> to the constructor instead. This way you get rid of an unnecessary level of indirection. It's not like the Factory object will ever be stateful anyway.

postamar · 2023-11-29T00:58:44Z

...gres/src/testFixtures/java/io/airbyte/integrations/source/postgres/PostgresTestDatabase.java

+
+    String methodName;
+
+    ImageModifier(String methodName) {


postamar

The only blocker on my end is s/ImageModifier/ContainerModifier/

stephane-airbyte · 2023-12-07T19:39:54Z

Merge activity

Dec 7, 2:39 PM: @@stephane-airbyte started a stack merge that includes this pull request via Graphite.
Dec 7, 2:40 PM: Graphite rebased this pull request as part of a merge.
Dec 7, 2:53 PM: @@stephane-airbyte merged this pull request with Graphite.

github-actions · 2023-12-07T19:45:44Z

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage	71.66%	🍏

using enum instead of strings for postgres container modifiers

stephane-airbyte mentioned this pull request Nov 28, 2023

introduce PostgresBaseImage #32851

Merged

octavia-squidington-iii added area/connectors Connector related issues connectors/source/postgres labels Nov 28, 2023

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from ec394c4 to b34a64a Compare November 28, 2023 21:01

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 4360a3f to e40bba3 Compare November 28, 2023 21:02

This was referenced Nov 28, 2023

introduce BaseImage for MsSql #32897

Merged

introduce ImageModifier to MS SQL source #32898

Merged

introduce BaseImage to MySql source #32899

Merged

introduce ImageModifier to MySql source #32900

Merged

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 709a565 to 42cbb0b Compare November 28, 2023 21:53

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from b34a64a to 9c55439 Compare November 28, 2023 22:02

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 6c20b52 to e8694b2 Compare November 28, 2023 22:02

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from 9c55439 to 1d1c6d8 Compare November 28, 2023 22:19

stephane-airbyte marked this pull request as ready for review November 28, 2023 22:19

stephane-airbyte requested a review from a team as a November 28, 2023 22:19

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 01d903c to 0e5a21f Compare November 28, 2023 22:19

postamar reviewed Nov 29, 2023

View reviewed changes

postamar suggested changes Nov 29, 2023

View reviewed changes

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 0e5a21f to 5b538b4 Compare November 29, 2023 17:58

octavia-squidington-iv requested a review from a team November 29, 2023 18:00

stephane-airbyte mentioned this pull request Nov 29, 2023

removing POSTGRES_16_ALPINE base image #32948

Merged

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from 1d1c6d8 to d0ab8c4 Compare November 29, 2023 19:03

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 5b538b4 to ee7be9a Compare November 29, 2023 19:03

This was referenced Nov 29, 2023

simplify MSSQL images #32951

Merged

simplify postgres base images #32952

Merged

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from e44faee to f3fb57a Compare December 2, 2023 17:44

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 4a4d2b4 to 90597c4 Compare December 2, 2023 17:44

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from f3fb57a to 8d01d2a Compare December 3, 2023 17:08

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch 2 times, most recently from 30a7d4a to 9ec7ab8 Compare December 3, 2023 17:59

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from 8d01d2a to e291199 Compare December 3, 2023 22:36

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 9ec7ab8 to f85604b Compare December 3, 2023 22:36

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from e291199 to d64b3f9 Compare December 5, 2023 19:33

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from f85604b to 1408f56 Compare December 5, 2023 19:34

octavia-squidington-iv requested review from a team December 5, 2023 19:35

katmarkham removed the request for review from a team December 6, 2023 17:38

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from 2981166 to d8f738c Compare December 7, 2023 01:27

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 7ca9aaf to 7496370 Compare December 7, 2023 04:08

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from 90780e5 to 08b4ae1 Compare December 7, 2023 04:24

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 7496370 to d108773 Compare December 7, 2023 04:24

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from 08b4ae1 to a0b2b49 Compare December 7, 2023 04:49

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from d108773 to 7aa296c Compare December 7, 2023 04:50

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from a0b2b49 to f8673f9 Compare December 7, 2023 06:32

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from 7aa296c to 1995d70 Compare December 7, 2023 06:32

stephane-airbyte force-pushed the 11-27-introduce_PostgresBaseImage branch from d1cbe9f to 42021c4 Compare December 7, 2023 16:41

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from b93ad8e to b89abae Compare December 7, 2023 16:41

Base automatically changed from 11-27-introduce_PostgresBaseImage to master December 7, 2023 19:40

introduce PostgresBaseImage

460d08d

stephane-airbyte force-pushed the 11-27-introduce_ImageModifier branch from b89abae to 460d08d Compare December 7, 2023 19:40

stephane-airbyte merged commit f1b91b3 into master Dec 7, 2023
23 of 35 checks passed

stephane-airbyte deleted the 11-27-introduce_ImageModifier branch December 7, 2023 19:53

rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023

introduce ImageModifier (airbytehq#32876)

b77a8dd

using enum instead of strings for postgres container modifiers

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

introduce ImageModifier #32876

introduce ImageModifier #32876

stephane-airbyte commented Nov 28, 2023 •

edited

Loading

vercel bot commented Nov 28, 2023 •

edited

Loading

stephane-airbyte commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023

postamar Nov 29, 2023

postamar Nov 29, 2023

postamar Nov 29, 2023

postamar left a comment

stephane-airbyte commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023

introduce ImageModifier #32876

introduce ImageModifier #32876

Conversation

stephane-airbyte commented Nov 28, 2023 • edited Loading

vercel bot commented Nov 28, 2023 • edited Loading

stephane-airbyte commented Nov 28, 2023 • edited Loading

github-actions bot commented Nov 28, 2023

Before Merging a Connector Pull Request

postamar Nov 29, 2023

Choose a reason for hiding this comment

postamar Nov 29, 2023

Choose a reason for hiding this comment

postamar Nov 29, 2023

Choose a reason for hiding this comment

postamar left a comment

Choose a reason for hiding this comment

stephane-airbyte commented Dec 7, 2023 • edited Loading

Merge activity

github-actions bot commented Dec 7, 2023

Coverage report for source-postgres

stephane-airbyte commented Nov 28, 2023 •

edited

Loading

vercel bot commented Nov 28, 2023 •

edited

Loading

stephane-airbyte commented Nov 28, 2023 •

edited

Loading

stephane-airbyte commented Dec 7, 2023 •

edited

Loading