Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify MSSQL images #32951

Merged
merged 1 commit into from
Dec 8, 2023
Merged

simplify MSSQL images #32951

merged 1 commit into from
Dec 8, 2023

Conversation

stephane-airbyte
Copy link
Contributor

remove MSSQL_2022_UBUNTU_2024. Rename into MSSQL_VERSION, get everything on latest

@stephane-airbyte stephane-airbyte requested a review from a team as a November 29, 2023 19:04
@vercel Vercel
Copy link

vercel bot commented Nov 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 8, 2023 3:04am

This was referenced Nov 29, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Nov 29, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@stephane-airbyte stephane-airbyte mentioned this pull request Nov 29, 2023
Merged
postamar
postamar reviewed Nov 29, 2023
View reviewed changes
airbyte-integrations/connectors/source-mssql/src/testFixtures/resources/testDockerFile Outdated
@@ -0,0 +1,2 @@
ARG BASE_IMAGE=mcr.microsoft.com/mssql/server:server:2022-latest
FROM ${BASE_IMAGE}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you commit this by mistake?

@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from db32274 to d229695 Compare November 29, 2023 20:55
@stephane-airbyte stephane-airbyte mentioned this pull request Nov 29, 2023
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from a5141b6 to 09cf3da Compare November 29, 2023 22:41
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from d229695 to b9f17a3 Compare November 29, 2023 22:41
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 29, 2023 22:43
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from 5614e97 to 9e69017 Compare November 30, 2023 22:07
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from beac1cb to 9fa77c4 Compare November 30, 2023 22:07
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from 9e69017 to 25e186a Compare December 1, 2023 00:29
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from 9fa77c4 to 7e489ca Compare December 1, 2023 00:29
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from 25e186a to 8cd6f17 Compare December 2, 2023 17:44
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from 7e489ca to f376aa4 Compare December 2, 2023 17:44
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from 8cd6f17 to 99237ed Compare December 3, 2023 17:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from f376aa4 to e976467 Compare December 3, 2023 17:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from 99237ed to a94d83c Compare December 3, 2023 18:00
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from e976467 to ac602de Compare December 3, 2023 18:00
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from a94d83c to 4e02343 Compare December 3, 2023 22:36
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from ac602de to a144530 Compare December 3, 2023 22:36
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from 4e02343 to 1011610 Compare December 7, 2023 01:27
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from a144530 to a4a3b1a Compare December 7, 2023 01:27
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 7, 2023 01:29
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from 1011610 to 3fe8077 Compare December 7, 2023 04:03
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from a4a3b1a to 21a57b1 Compare December 7, 2023 04:03
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from 3fe8077 to d990f5d Compare December 7, 2023 04:51
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from 21a57b1 to 32a580f Compare December 7, 2023 04:52
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from d990f5d to 539cb9a Compare December 7, 2023 06:32
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from 32a580f to c5cb7e6 Compare December 7, 2023 06:32
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from 92d9d58 to c424660 Compare December 7, 2023 16:41
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from 1429d75 to af89055 Compare December 7, 2023 16:41
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from c424660 to ced9b13 Compare December 7, 2023 22:49
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from af89055 to 1454eb9 Compare December 7, 2023 22:49
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-removing_POSTGRES_16_ALPINE_base_image branch from ced9b13 to a0be010 Compare December 8, 2023 00:29
Base automatically changed from stephane/11-29-removing_POSTGRES_16_ALPINE_base_image to master December 8, 2023 00:41
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from 1454eb9 to 99f2e93 Compare December 8, 2023 00:42
@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Dec 8, 2023 •
edited
Loading

Merge activity

  • Dec 7, 7:42 PM: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Dec 7, 10:16 PM: @@stephane-airbyte merged this pull request with Graphite.

@stephane-airbyte
simplify MSSQL images
1b87746 
remove MSSQL_2022_UBUNTU_2024. Rename into MSSQL_VERSION, get everything on latest
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_MSSQL_images branch from 99f2e93 to 1b87746 Compare December 8, 2023 03:04
@stephane-airbyte stephane-airbyte merged commit dccd48a into master Dec 8, 2023
15 of 16 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/11-29-simplify_MSSQL_images branch December 8, 2023 03:16
rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
@stephane-airbyte @rishabh-cldcvr
simplify MSSQL images (airbytehq#32951)
4ed749a 
remove MSSQL_2022_UBUNTU_2024. Rename into MSSQL_VERSION, get everything on latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postamar postamar postamar approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/mssql connectors/source/mysql connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephane-airbyte @postamar @octavia-squidington-iii