Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce BaseImage to MySql source #32899

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Nov 28, 2023

introduce baseImage to MySql so we don't use strings everywhere

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 11:27pm

Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 526176d to a32ec12 Compare November 28, 2023 21:53
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from 540ee6f to af5d70a Compare November 28, 2023 21:53
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 3838088 to 5a1239e Compare November 28, 2023 22:03
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from a874989 to 554e180 Compare November 28, 2023 22:03
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from c6b200c to 3d5f575 Compare November 28, 2023 22:19
@stephane-airbyte stephane-airbyte marked this pull request as ready for review November 28, 2023 22:19
@stephane-airbyte stephane-airbyte requested a review from a team as a November 28, 2023 22:19
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from 962ad12 to a272072 Compare November 28, 2023 22:19
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 3d5f575 to 7f02ef2 Compare November 29, 2023 18:00
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from a272072 to f8509d7 Compare November 29, 2023 18:00
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 29, 2023 18:02
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 7f02ef2 to bf2cba7 Compare November 29, 2023 19:03
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from f8509d7 to a0ae2fe Compare November 29, 2023 19:03
This was referenced Nov 29, 2023
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 8613647 to 78c7142 Compare December 2, 2023 17:44
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from 43f470a to a1f7ecc Compare December 2, 2023 17:44
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 78c7142 to 12e5e0d Compare December 3, 2023 17:25
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from a1f7ecc to e534e2d Compare December 3, 2023 17:25
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 12e5e0d to dff7f13 Compare December 3, 2023 17:59
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from e534e2d to 87b5ebb Compare December 3, 2023 17:59
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from dff7f13 to ef32330 Compare December 3, 2023 22:36
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from 87b5ebb to 27d88ed Compare December 3, 2023 22:36
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from ef32330 to baa9296 Compare December 7, 2023 01:27
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from 27d88ed to ca82899 Compare December 7, 2023 01:27
@octavia-squidington-iv octavia-squidington-iv requested review from a team December 7, 2023 01:28
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from baa9296 to 38a2e15 Compare December 7, 2023 04:03
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from ca82899 to 5f3202a Compare December 7, 2023 04:03
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 38a2e15 to 4771e13 Compare December 7, 2023 04:50
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from 5f3202a to 71cf625 Compare December 7, 2023 04:51
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 4771e13 to 906b336 Compare December 7, 2023 06:32
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from 71cf625 to c6381b1 Compare December 7, 2023 06:32
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 11b883a to 14a54d5 Compare December 7, 2023 16:41
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from 7caa019 to 2d513c5 Compare December 7, 2023 16:41
Copy link
Contributor Author

stephane-airbyte commented Dec 7, 2023

Merge activity

@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from 14a54d5 to d4497c5 Compare December 7, 2023 22:49
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from 2d513c5 to cd1973f Compare December 7, 2023 22:49
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_ImageModifier_to_MS_SQL_source branch from d4497c5 to 7399531 Compare December 7, 2023 23:08
Base automatically changed from 11-28-introduce_ImageModifier_to_MS_SQL_source to master December 7, 2023 23:26
@stephane-airbyte stephane-airbyte force-pushed the 11-28-introduce_BaseImage_to_MySql_source branch from cd1973f to 18f75ad Compare December 7, 2023 23:27
@stephane-airbyte stephane-airbyte merged commit 0b8b11b into master Dec 7, 2023
15 of 16 checks passed
@stephane-airbyte stephane-airbyte deleted the 11-28-introduce_BaseImage_to_MySql_source branch December 7, 2023 23:38
rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
introduce baseImage to MySql so we don't use strings everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants