Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename getImageModifiers into getContainerModifiers everywhere #32958

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Nov 29, 2023

simple refactor

@stephane-airbyte stephane-airbyte requested a review from a team as a November 29, 2023 20:55
Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Dec 8, 2023 3:56am

Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 1d46108 to a15e230 Compare November 29, 2023 22:41
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from 06302ad to d96f3ad Compare November 29, 2023 22:41
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 29, 2023 22:43
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 8517f68 to e14afae Compare November 30, 2023 22:07
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from 5012561 to 37305ae Compare November 30, 2023 22:07
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from e14afae to 51a44ca Compare December 1, 2023 00:29
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from 37305ae to 45f8902 Compare December 1, 2023 00:29
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 51a44ca to 83187ca Compare December 2, 2023 17:44
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from 45f8902 to 2bd8ff0 Compare December 2, 2023 17:44
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 83187ca to c12131a Compare December 3, 2023 17:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from 2bd8ff0 to c9478f8 Compare December 3, 2023 17:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from c12131a to 6fd4208 Compare December 3, 2023 18:00
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from c9478f8 to e707758 Compare December 3, 2023 18:00
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 6fd4208 to 82d5ff0 Compare December 3, 2023 22:36
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from e707758 to dcba5b5 Compare December 3, 2023 22:37
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 82d5ff0 to 197b3db Compare December 7, 2023 01:27
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from dcba5b5 to c73d3d5 Compare December 7, 2023 01:27
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 7, 2023 01:30
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 1f1a1d4 to 0fac3e7 Compare December 7, 2023 04:03
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from bd52d18 to 98c1949 Compare December 7, 2023 04:03
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from ea69aa7 to 9d80e95 Compare December 7, 2023 04:52
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from adefb26 to d72bc65 Compare December 7, 2023 04:54
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 9d80e95 to 6d2bc7c Compare December 7, 2023 05:41
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch 2 times, most recently from a8ee2d8 to 5263f92 Compare December 7, 2023 06:03
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 6d2bc7c to d92617f Compare December 7, 2023 06:33
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from 5263f92 to 5bd7c59 Compare December 7, 2023 06:33
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from f8c1944 to cb29338 Compare December 7, 2023 16:41
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from ce9adfb to b09a578 Compare December 7, 2023 16:41
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from cb29338 to 197cd84 Compare December 7, 2023 22:49
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from b09a578 to dd5688d Compare December 7, 2023 22:49
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 197cd84 to 2f5c94b Compare December 8, 2023 03:04
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from dd5688d to 9a69706 Compare December 8, 2023 03:04
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-simplify_postgres_base_images branch from 2f5c94b to be6585d Compare December 8, 2023 03:26
Base automatically changed from stephane/11-29-simplify_postgres_base_images to master December 8, 2023 03:37
@stephane-airbyte stephane-airbyte force-pushed the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch from 9a69706 to e747fd5 Compare December 8, 2023 03:56
@stephane-airbyte stephane-airbyte merged commit 3cc5188 into master Dec 8, 2023
15 of 16 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/11-29-rename_getImageModifiers_into_getContainerModifiers_everywhere branch December 8, 2023 04:08
Copy link
Contributor Author

Merge activity

rishabh-cldcvr pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants