Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): tolerate entra id RFC8414 deviation #3359

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

krancour
Copy link
Member

@krancour krancour commented Jan 24, 2025

MS Entra ID (formerly Azure AD) implements OIDC and PKCE, but deviates from RFC8414 (OAuth 2.0 Authorization Server Metadata) by failing to include the code_challenge_method in its metadata. This can create the impression that it does not support PKCE.

Up to now, this has been the cause of a (previously unknown) incompatibility with our UI.

This PR adds an explicit exception to the expectation that code_challenge_method exists and includes the value "S256" for Entra ID only.

This is safe, as support for S256 is documented here: https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 062de60
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6793e92d0283d70008c8bb13
😎 Deploy Preview https://deploy-preview-3359.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.47%. Comparing base (5b27901) to head (062de60).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3359   +/-   ##
=======================================
  Coverage   52.47%   52.47%           
=======================================
  Files         291      291           
  Lines       26617    26617           
=======================================
  Hits        13968    13968           
  Misses      11886    11886           
  Partials      763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour force-pushed the krancour/oidc-entra-fix branch from 0ac6d16 to 062de60 Compare January 24, 2025 19:25
@krancour krancour changed the title fix(ui): tolerate entra id pkce spec deviation fix(ui): tolerate entra id RFC8414 deviation Jan 24, 2025
@krancour krancour added this pull request to the merge queue Jan 24, 2025
Merged via the queue into akuity:main with commit b4458c5 Jan 24, 2025
19 checks passed
@krancour krancour deleted the krancour/oidc-entra-fix branch January 24, 2025 20:44
github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
Signed-off-by: Kent Rancourt <[email protected]>
(cherry picked from commit b4458c5)
@akuitybot
Copy link

Successfully created backport PR for release-1.2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants