fix(ui): tolerate entra id RFC8414 deviation #3359
Merged
+8
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MS Entra ID (formerly Azure AD) implements OIDC and PKCE, but deviates from RFC8414 (OAuth 2.0 Authorization Server Metadata) by failing to include the
code_challenge_method
in its metadata. This can create the impression that it does not support PKCE.Up to now, this has been the cause of a (previously unknown) incompatibility with our UI.
This PR adds an explicit exception to the expectation that
code_challenge_method
exists and includes the value"S256"
for Entra ID only.This is safe, as support for S256 is documented here: https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow