Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tendermint-rs to v0.38 #3735

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Update tendermint-rs to v0.38 #3735

merged 4 commits into from
Sep 6, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Aug 30, 2024

Describe your changes

  • Update tendermint-rs, ibc-rs (based on v0.54), prost, and tower-abci

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@yito88 yito88 requested a review from tzemanovic August 30, 2024 13:14
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (ef49b3d) to head (0dfcfbf).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
crates/ibc/src/event.rs 0.00% 13 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 10 Missing ⚠️
crates/ibc/src/context/common.rs 55.00% 9 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 4 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3735      +/-   ##
==========================================
- Coverage   72.50%   72.49%   -0.01%     
==========================================
  Files         338      338              
  Lines      104190   104196       +6     
==========================================
- Hits        75541    75535       -6     
- Misses      28649    28661      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 2, 2024
mergify bot added a commit that referenced this pull request Sep 2, 2024
mergify bot added a commit that referenced this pull request Sep 2, 2024
Copy link
Contributor

mergify bot commented Sep 2, 2024

Hey @yito88, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Sep 2, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@Fraccaman
Copy link
Member

@mergify queue

Copy link
Contributor

mergify bot commented Sep 4, 2024

queue

🛑 The pull request has been removed from the queue main-queue

The pull request conflicts with at least one pull request ahead in queue.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link
Contributor

mergify bot commented Sep 6, 2024

Hey @yito88, your pull request has been dequeued due to the following reason: CONFLICT_WITH_PULL_AHEAD.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

mergify bot added a commit that referenced this pull request Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
Copy link
Contributor

mergify bot commented Sep 6, 2024

Hey @yito88, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Sep 6, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
Copy link
Contributor

mergify bot commented Sep 6, 2024

Hey @yito88, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

mergify bot added a commit that referenced this pull request Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
Copy link
Contributor

mergify bot commented Sep 6, 2024

Hey @yito88, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@brentstone
Copy link
Collaborator

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Sep 6, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Sep 6, 2024
mergify bot added a commit that referenced this pull request Sep 6, 2024
@mergify mergify bot merged commit 4e0e215 into main Sep 6, 2024
21 of 23 checks passed
@mergify mergify bot deleted the yuji/tendermint-0.38 branch September 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants