mv gov sub-module from shell into gov crate

[tzemanovic]

Describe your changes

• related to Code coverage audit, rework to obtain coverage w/o large E2E tests #1497

Checklist before merging

• If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
  • This will require 2 reviewers to approve the changes

[codecov]

Codecov Report

Attention: Patch coverage is 82.91874% with 103 lines in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (ef00f27) to head (96d8e23).
Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/governance/src/finalize_block.rs	81.86%	78 Missing ⚠️
crates/node/src/shell/finalize_block.rs	72.97%	20 Missing ⚠️
crates/node/src/protocol.rs	0.00%	3 Missing ⚠️
crates/trans_token/src/lib.rs	95.45%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3718      +/-   ##
==========================================
+ Coverage   72.41%   72.47%   +0.05%     
==========================================
  Files         335      334       -1     
  Lines      104005   104127     +122     
==========================================
+ Hits        75320    75464     +144     
+ Misses      28685    28663      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Fraccaman]

another nice refactor, thanks @tzemanovic! We merged #3601, you need to rebase on main to fix e2e test that is failing!

[tzemanovic]

I've added one more refactor to get rid of the tx and vp cache being passed through in 1e319fb

[mergify]

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

[tzemanovic]

@Mergifyio requeue

[mergify]

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

[mergify]

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

[tzemanovic]

@Mergifyio requeue

[mergify]

requeue

❌ This pull request head commit has not been previously disembarked from queue.

[tzemanovic]

the integration::ledger_tests::pgf_governance_proposal keeps failing in CI but locally it passes for me :/

[brentstone]

@tzemanovic I was having the same problem with that failing test in #3691 - at some point after a rebasing on main it passed but I never figured out why it was failing in CI

[tzemanovic]

this one started failing after rebase - same in #3735