-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dry run #3758
Improve dry run #3758
Conversation
1c91f7a
to
999a89c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3758 +/- ##
=======================================
Coverage 72.41% 72.42%
=======================================
Files 335 335
Lines 104005 103968 -37
=======================================
- Hits 75320 75299 -21
+ Misses 28685 28669 -16 ☔ View full report in Codecov by Sentry. |
Hey @grarco, your pull request has been dequeued due to the following reason: CONFLICT_WITH_PULL_AHEAD. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
999a89c
to
59fdda8
Compare
Describe your changes
Closes #3360.
Fixes some bugs in the dry-run implementation and refactors it to reuse
dispatch_inner_txs
instead of rebuilding the same logic.Also some misc updates to comments/error messages.
This PR is based on #3746 (diffs: https://github.com/anoma/namada/pull/3758/files/9aee33a0c44bf0ab70da18185727ba664d6b60d9..999a89c11a908a4a4130c05be4c34c3003dd4e23)
Checklist before merging
breaking::
labels