Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (bd686dc), #3735 and #3715 together #3773

Closed
wants to merge 15 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 6, 2024

✨ Pull request #3735 which was ahead in the queue has been dequeued. The pull request #3715 has been re-embarked. ✨

Branch main (bd686dc), #3735 and #3715 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3715.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • any of [🛡 GitHub branch protection]:
    • check-neutral=check-benchmarks
    • check-skipped=check-benchmarks
    • check-success=check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-neutral=check-packages
    • check-skipped=check-packages
    • check-success=check-packages
  • any of [🛡 GitHub branch protection]:
    • check-neutral=build-binaries
    • check-skipped=build-binaries
    • check-success=build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-neutral=lints
    • check-skipped=lints
    • check-success=lints
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-unit
    • check-skipped=test-unit
    • check-success=test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (0)
    • check-skipped=test-e2e (0)
    • check-success=test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (1)
    • check-skipped=test-e2e (1)
    • check-success=test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (2)
    • check-skipped=test-e2e (2)
    • check-success=test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (3)
    • check-skipped=test-e2e (3)
    • check-success=test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (4)
    • check-skipped=test-e2e (4)
    • check-success=test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-integration
    • check-skipped=test-integration
    • check-success=test-integration
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-wasm
    • check-skipped=test-wasm
    • check-success=test-wasm
  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-neutral=Mergify Merge Protections
    • check-skipped=Mergify Merge Protections
    • check-success=Mergify Merge Protections
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )

Required conditions to stay in the queue:

  • #approved-reviews-by >= 1
  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • base = main
  • any of [🛡 GitHub branch protection]:
    • check-neutral=Mergify Merge Protections
    • check-skipped=Mergify Merge Protections
    • check-success=Mergify Merge Protections
  • any of [🛡 GitHub branch protection]:
    • check-success=check-benchmarks
    • check-neutral=check-benchmarks
    • check-skipped=check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success=check-packages
    • check-neutral=check-packages
    • check-skipped=check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success=build-binaries
    • check-neutral=build-binaries
    • check-skipped=build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • any of [🛡 GitHub branch protection]:
    • check-success=lints
    • check-neutral=lints
    • check-skipped=lints
  • any of [🛡 GitHub branch protection]:
    • check-success=test-unit
    • check-neutral=test-unit
    • check-skipped=test-unit
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (0)
    • check-neutral=test-e2e (0)
    • check-skipped=test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (1)
    • check-neutral=test-e2e (1)
    • check-skipped=test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (2)
    • check-neutral=test-e2e (2)
    • check-skipped=test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (3)
    • check-neutral=test-e2e (3)
    • check-skipped=test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (4)
    • check-neutral=test-e2e (4)
    • check-skipped=test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-integration
    • check-neutral=test-integration
    • check-skipped=test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success=test-wasm
    • check-neutral=test-wasm
    • check-skipped=test-wasm
---
previous_failed_batches: []
pull_requests:
  - number: 3715
...

@mergify mergify bot closed this Sep 6, 2024
@mergify mergify bot deleted the mergify/merge-queue/083456298b branch September 6, 2024 15:14
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 71.63462% with 59 lines in your changes missing coverage. Please review.

Project coverage is 72.68%. Comparing base (bd686dc) to head (88f245e).

Files with missing lines Patch % Lines
crates/ibc/src/event.rs 0.00% 13 Missing ⚠️
crates/sdk/src/tx.rs 40.00% 12 Missing ⚠️
crates/ibc/src/context/common.rs 55.00% 9 Missing ⚠️
crates/core/src/key/common.rs 79.48% 8 Missing ⚠️
crates/core/src/hash.rs 84.84% 5 Missing ⚠️
crates/tx/src/lib.rs 91.37% 5 Missing ⚠️
crates/sdk/src/signing.rs 33.33% 4 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3773      +/-   ##
==========================================
+ Coverage   72.49%   72.68%   +0.18%     
==========================================
  Files         338      338              
  Lines      104195   104320     +125     
==========================================
+ Hits        75541    75829     +288     
+ Misses      28654    28491     -163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants