Validate concurrent commits in DynamicIcebergSink to prevent commit duplication #14517
+311
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2025
Change-Id: Id5fb471eb4234168093fbbe5e7ccf3607794ddc9
aiborodin
force-pushed
the
fix-commit-duplication-in-flink
branch
from
36f03a9 to
90877bf
Compare
Contributor
Author
|
@pvary, I updated this PR with the new API that was recently merged. |
pvary
reviewed
Nov 7, 2025
| lastCommittedCheckpointId = Long.parseLong(value); | ||
| break; | ||
| } | ||
| @Nullable |
Contributor
There was a problem hiding this comment.
nit: this annotation doesn't add much info, since we immediately check the null value after the line.
Please remove it.
pvary
reviewed
Nov 7, 2025
| } | ||
|
|
||
| @Nullable | ||
| private static Long extractCommittedCheckpointId( |
Contributor
There was a problem hiding this comment.
Could we change the getMaxCommittedCheckpointId to use Iterable<Snapshot> baseSnapshots instead of the table parameter? In this case we can reuse the same method, and we don't need to write some spagetti code.
And in the original place we could just add
table.snapshot(branch) != null
? SnapshotUtil.ancestorsOf(table.snapshot(branch).snapshotId(), table::snapshot)
: List.of();
pvary
reviewed
Nov 7, 2025
| public String errorMessage() { | ||
| if (errorMessage == null) { | ||
| return SnapshotAncestryValidator.super.errorMessage(); | ||
| } |
Contributor
There was a problem hiding this comment.
nit: newlines after blocks. See: https://iceberg.apache.org/contribute/#block-spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue in #14425 by validating that no concurrent commit has moved the
flink.max-committed-checkpoint-idinDynamicIcebergSinkthat would not be seen by the committer due to the table refreshing during the commit process.