Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-power-calendar, ember-power-select & ember-concurrency #1454

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

future-pirate-king
Copy link
Contributor

No description provided.

Copy link

coderabbitai bot commented Sep 10, 2024

Walkthrough

This pull request introduces multiple modifications across various files in an Ember.js application. Key changes include updates to the ak-select component's properties and methods, the addition of new placeholder functionality in regulatory categories, and the introduction of a new dropdown component in the application template. Import paths have been adjusted for clarity, and several dependencies in package.json have been added or updated. Type definitions have also been restructured in global.d.ts, reflecting changes in the component registry.

Changes

Files Change Summary
app/components/ak-select/index.hbs, app/components/ak-select/index.ts Modified the @onOpen property and added @horizontalPosition to the ak-select component. Updated the required property type in the component interface and added an onOpen action method.
app/components/security/analysis-details/regulatory-categories/index.hbs, app/components/security/analysis-details/regulatory-categories/index.ts Changed the placeholder attribute to a dynamic value in the ak-select component and added placeholder properties to regulatory category objects.
app/templates/application.hbs Introduced a new <BasicDropdownWormhole /> component in the application template.
ember-cli-build.js Added Babel configuration for the ember-concurrency/async-arrow-task-transform plugin.
package.json Added and updated several dependencies, including ember-basic-dropdown, ember-concurrency, ember-power-calendar, and ember-power-select.
tests/... Adjusted import paths for various test files to reflect changes in the ember-power-select and ember-power-calendar libraries.
types/global.d.ts Restructured type definitions, added new type dependencies, and removed the PowerSelectExtendedArgs interface.

Poem

🐇 In the meadow, changes bloom,
New dropdowns dance, dispelling gloom.
Selects now sing with placeholders bright,
Code's a garden, growing with delight!
With hops and skips, we cheer the way,
For every tweak makes a brighter day! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 654a0a7 and 5071012.

Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • staticserver/package-lock.json is excluded by !**/package-lock.json
Files selected for processing (19)
  • app/components/ak-select/index.hbs (1 hunks)
  • app/components/ak-select/index.ts (2 hunks)
  • app/components/security/analysis-details/regulatory-categories/index.hbs (1 hunks)
  • app/components/security/analysis-details/regulatory-categories/index.ts (15 hunks)
  • app/templates/application.hbs (1 hunks)
  • ember-cli-build.js (1 hunks)
  • package.json (4 hunks)
  • staticserver/package.json (1 hunks)
  • tests/acceptance/app-monitoring/settings-test.js (1 hunks)
  • tests/acceptance/sbom-test.js (1 hunks)
  • tests/integration/components/ak-date-picker-test.js (1 hunks)
  • tests/integration/components/ak-select-test.js (1 hunks)
  • tests/integration/components/organization-archive-test.js (1 hunks)
  • tests/integration/components/project-list-test.js (1 hunks)
  • tests/integration/components/project-settings/general-settings/github-project-test.js (1 hunks)
  • tests/integration/components/project-settings/general-settings/jira-project-test.js (1 hunks)
  • tests/integration/components/security/analysis-details-test.js (1 hunks)
  • tests/integration/components/security/analysis-list-test.js (1 hunks)
  • types/global.d.ts (3 hunks)
Files skipped from review due to trivial changes (8)
  • app/components/security/analysis-details/regulatory-categories/index.ts
  • app/templates/application.hbs
  • tests/acceptance/sbom-test.js
  • tests/integration/components/project-list-test.js
  • tests/integration/components/project-settings/general-settings/github-project-test.js
  • tests/integration/components/project-settings/general-settings/jira-project-test.js
  • tests/integration/components/security/analysis-details-test.js
  • tests/integration/components/security/analysis-list-test.js
Files skipped from review as they are similar to previous changes (11)
  • app/components/ak-select/index.hbs
  • app/components/ak-select/index.ts
  • app/components/security/analysis-details/regulatory-categories/index.hbs
  • ember-cli-build.js
  • package.json
  • staticserver/package.json
  • tests/acceptance/app-monitoring/settings-test.js
  • tests/integration/components/ak-date-picker-test.js
  • tests/integration/components/ak-select-test.js
  • tests/integration/components/organization-archive-test.js
  • types/global.d.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2024

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5071012
Status: ✅  Deploy successful!
Preview URL: https://86f35e2e.irenestaging.pages.dev
Branch Preview URL: https://pd-1495-ember-dep-upgrades.irenestaging.pages.dev

View logs

Copy link

cypress bot commented Sep 10, 2024

Irene    Run #467

Run Properties:  status check failed Failed #467  •  git commit f9eeab117d ℹ️: Merge 739c90bd0a8523480f55d924a9c6a0656dfc9df4 into 1a66538997565c9d7024066b4706...
Project Irene
Branch Review PD-1495-ember-dep-upgrades
Run status status check failed Failed #467
Run duration 05m 20s
Commit git commit f9eeab117d ℹ️: Merge 739c90bd0a8523480f55d924a9c6a0656dfc9df4 into 1a66538997565c9d7024066b4706...
Committer Sam David
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 1
Tests that passed  Passing 20
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/tests/dynamic-scan.spec.ts • 1 failed test

View Output

Test Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062 Test Replay Screenshots

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants