-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtual_disks: stabilize tests that check a new disk was added #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitterl
force-pushed
the
ndb_fix_s390x
branch
6 times, most recently
from
July 27, 2023 15:23
e8c23b1
to
1e812a8
Compare
smitterl
changed the title
virtual_disks_nbd: stabilize test on s390x
virtual_disks: stabilize tests on s390x
Jul 27, 2023
smitterl
changed the title
virtual_disks: stabilize tests on s390x
virtual_disks: stabilize tests that check a new disk was added
Jul 28, 2023
smitterl
force-pushed
the
ndb_fix_s390x
branch
2 times, most recently
from
July 28, 2023 14:15
4d70333
to
b695554
Compare
Partition names under /cat/partitions might change between boots, causing tests to fail in those cases. Use instead information under /dev/disk/by-path. Note, that pci disks might be listed twice, e.g. 'virtio-pci-0000:04:00.0-part1' and 'pci-0000:04:00.0-part1'. Furthermore, virtual_disk_ndb: remove unused parameter startupPolicy: disable floppy, sata - not available on s390x Signed-off-by: Sebastian Mitterle <[email protected]>
RHEL 9 s390x
startup_policy.startupPolicy.mandatory.device_type.disk.virtio_bus.volume.dir_pool fails on RHEL 9 where it's not supported but skipped but passes on RHEL 8:
Also, run these tests on x86_64, same result. |
chunfuwen
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
known minor fix, mark it as minor_fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on avocado-framework/avocado-vt#3729
Partition names under /cat/partitions might change
between boots, causing tests to fail in those cases.
Use instead information under /dev/disk/by-path.
Note, that pci disks might be listed twice, e.g.
'virtio-pci-0000:04:00.0-part1' and 'pci-0000:04:00.0-part1'.
Furthermore,
virtual_disk_ndb: remove unused parameter
startupPolicy: disable floppy, sata - not available on s390x