Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(global_parameter_loader): add gtest to global parameter loader #5021

Conversation

cyn-liu
Copy link
Contributor

@cyn-liu cyn-liu commented Sep 18, 2023

Description

Add test to global_parameter_loader node

Related links

Tests performed

pass

Notes for reviewers

Interface changes

Effects on system behavior

Add test in src/universe/autoware.universe/common/global_parameter_loader.
There is no effect on the function.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 18, 2023
@cyn-liu cyn-liu force-pushed the add-gtest-of-global-parameter-loader branch from 7de511a to 1d3d370 Compare September 18, 2023 09:56
@cyn-liu cyn-liu changed the title Add gtest of global_parameter_loader feat(global_parameter_loader): Add gtest to global_parameter_loader Sep 18, 2023
@cyn-liu cyn-liu closed this Sep 18, 2023
@cyn-liu cyn-liu deleted the add-gtest-of-global-parameter-loader branch September 18, 2023 10:18
@cyn-liu cyn-liu restored the add-gtest-of-global-parameter-loader branch September 18, 2023 10:19
@cyn-liu cyn-liu reopened this Sep 18, 2023
@cyn-liu cyn-liu force-pushed the add-gtest-of-global-parameter-loader branch from c51548a to 7a341d8 Compare September 18, 2023 10:31
@cyn-liu cyn-liu changed the title feat(global_parameter_loader): Add gtest to global_parameter_loader feat(global_parameter_loader): Add gtest to global parameter loader Sep 18, 2023
@cyn-liu cyn-liu changed the title feat(global_parameter_loader): Add gtest to global parameter loader feat(global_parameter_loader): add gtest to global parameter loader Sep 18, 2023
@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2023
@liuXinGangChina
Copy link

liuXinGangChina commented Sep 20, 2023

add a tag or lable to activate the ci/cd pipeline
run-build-and-test-differential

@cyn-liu
Copy link
Contributor Author

cyn-liu commented Sep 20, 2023

DCO is failed, but I don't know why, my git log is normal:
MicrosoftTeams-image (1)

The other required pipeline is failed due to test_global_params_launch.cpp I wrote, but this test is success in my project, and the error information is confusing:
image

@yukkysaito yukkysaito added the component:system System design and integration. (auto-assigned) label Sep 21, 2023
@yukkysaito yukkysaito self-requested a review September 21, 2023 10:00
@mitsudome-r
Copy link
Member

Could you update the changes from the latest main?

@github-actions github-actions bot removed the component:system System design and integration. (auto-assigned) label Nov 2, 2023
@mitsudome-r
Copy link
Member

@cyn-liu Friendly ping.

@mitsudome-r mitsudome-r enabled auto-merge (squash) December 20, 2023 07:29
Copy link

stale bot commented Feb 18, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Feb 18, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Feb 21, 2024
@cyn-liu cyn-liu force-pushed the add-gtest-of-global-parameter-loader branch from d7fe12c to ca91cd0 Compare March 12, 2024 05:38
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (1b45a7e) to head (f2223fb).
Report is 45 commits behind head on main.

Files Patch % Lines
...arameter_loader/test/test_global_params_launch.cpp 41.66% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5021   +/-   ##
=======================================
  Coverage   14.78%   14.78%           
=======================================
  Files        1917     1918    +1     
  Lines      132038   132050   +12     
  Branches    39228    39235    +7     
=======================================
+ Hits        19524    19529    +5     
  Misses      90726    90726           
- Partials    21788    21795    +7     
Flag Coverage Δ *Carryforward flag
differential 23.23% <41.66%> (?)
total 14.78% <ø> (ø) Carriedforward from 1b45a7e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyn-liu cyn-liu force-pushed the add-gtest-of-global-parameter-loader branch from 446c171 to e835260 Compare March 12, 2024 08:29
@mitsudome-r mitsudome-r merged commit dfec62a into autowarefoundation:main Apr 3, 2024
26 checks passed
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Apr 5, 2024
…utowarefoundation#5021)

* add remote

* feat(global_parameter_loader): add gtest of global-parameter-loader

Signed-off-by: Cynthia Liu <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Cynthia Liu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
esteve pushed a commit that referenced this pull request Apr 9, 2024
…5021)

* add remote

* feat(global_parameter_loader): add gtest of global-parameter-loader

Signed-off-by: Cynthia Liu <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Cynthia Liu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…utowarefoundation#5021)

* add remote

* feat(global_parameter_loader): add gtest of global-parameter-loader

Signed-off-by: Cynthia Liu <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Cynthia Liu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants