feat(tier4_system_rviz_plugin): improve visualization results and logics #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen-Liuyuxuan <[email protected]>
github-actions
bot
added
the
component:common
Owen-Liuyuxuan
changed the title
Owen-Liuyuxuan
changed the title
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
kminoda
reviewed
Oct 4, 2023
There was a problem hiding this comment.
Thank you for the PR! Understood the idea behind this, and I am definitely for it.
However, IMHO, using the diag topics for detecting if the planning and localization is initialized or not is a bit hacky, making the system overcomplicated. For example if the diag name in the subscribed topic changes, this plugin may not work properly.
Instead, I would recommend using ADAPI instead, which is a formal way of knowing the state of the Autoware system. You may refer to https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/ad-api/.
Signed-off-by: Owen-Liuyuxuan <[email protected]>
github-actions
bot
added
the
type:documentation
|
Sorry, let me review this by tomorrow. Thanks! |
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
kminoda
reviewed
Oct 12, 2023
common/tier4_system_rviz_plugin/src/mrm_summary_overlay_display.cpp
Outdated
Show resolved
Hide resolved
kminoda
added
the
run:build-and-test-differential
Merged
4 tasks
Signed-off-by: Owen-Liuyuxuan <[email protected]>
shmpwk
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The great PR #4945 added the visualization functionality for HazardStatus messages, which is important in daily testing. However, there are two problems that make the RVIz plugin not perfect enough for everyday usage.
In this PR, we
Related links
Tests performed
PSim
No text print out when running normally or just started
Print out text as the original PR when errors/warnings received.
Notes for reviewers
Interface changes
NA
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.