feat(tier4_system_rviz_plugin): improve visualization results and logics #5222
This check has been archived and is scheduled for deletion.
Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Oct 12, 2023 in 37s
CodeScene PR Check
✅ Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
🚩 Negative Code Health Impact (highest to lowest):
- Complex Method mrm_summary_overlay_display.cpp: MrmSummaryOverlayDisplay::update
Annotations
Check warning on line 233 in common/tier4_system_rviz_plugin/src/mrm_summary_overlay_display.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
MrmSummaryOverlayDisplay::update has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 233 in common/tier4_system_rviz_plugin/src/mrm_summary_overlay_display.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Bumpy Road Ahead
MrmSummaryOverlayDisplay::update increases from 2 to 4 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading