refactor(behavior_velocity_planner): rework parameters #5263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuntianyi-chen <[email protected]>
yuntianyi-chen
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
maxime-clem,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
TomohitoAndo,
tkimura4 and
purewater0901
as code owners
github-actions
bot
added
the
component:planning
Signed-off-by: yuntianyi-chen <[email protected]>
|
@yuntianyi-chen Thanks for your contribution. Unfortunatelly, it seems that this PR has conflicts. Could you fix it at first? After that I'll review this asap. |
….universe into refactor-ros-config-behavior_velocity_planner
Signed-off-by: yuntianyi-chen <[email protected]>
Signed-off-by: yuntianyi-chen <[email protected]>
…b.com:yuntianyi-chen/autoware.universe into refactor-ros-config-behavior_velocity_planner
I've resolved the conflicts. Please review them! |
satoshi-ota
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5263 +/- ##
===========================================
+ Coverage 15.32% 27.91% +12.58%
===========================================
Files 1721 3 -1718
Lines 118559 326 -118233
Branches 37995 185 -37810
===========================================
- Hits 18169 91 -18078
+ Misses 79657 83 -79574
+ Partials 20733 152 -20581
☔ View full report in Codecov by Sentry. |
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…ation#5263) * refactor node behavior_velocity_planner Signed-off-by: yuntianyi-chen <[email protected]> * delete some statements in launch file Signed-off-by: yuntianyi-chen <[email protected]> * Modify the launch file Signed-off-by: yuntianyi-chen <[email protected]> * style(pre-commit): autofix * update launch file Signed-off-by: yuntianyi-chen <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: yuntianyi-chen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Satoshi OTA <[email protected]>
xmfcx
reviewed
Feb 20, 2024
planning/behavior_velocity_planner/schema/behavior_velocity_planner.schema.json
Show resolved
Hide resolved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the ROS Node configuration layout for the behavior_velocity_planner package according to the guideline.
Related links
None
Tests performed
Output an error when launching this node individually since this launch file is dependent on other nodes.
Notes for reviewers
None
Interface changes
planning/behavior_velocity_planner/schema/behavior_velocity_planner.schema.jsonEffects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.